gf conditions: get tagging data from 2nd sheet #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2024
com.google.fonts/check/metadata/has_tags On the Google Fonts profile Also fetch family tagging data from a second Google Sheet (Submissions from designers via form: https://forms.gle/jcp3nDv63LaV1rxH6) (PR #4576)
com.google.fonts/check/metadata/has_tags On the Google Fonts profile Also fetch family tagging data from a second Google Sheet (Submissions from designers via form: https://forms.gle/jcp3nDv63LaV1rxH6) (PR #4576)
felipesanches
pushed a commit
that referenced
this pull request
Mar 4, 2024
com.google.fonts/check/metadata/has_tags On the Google Fonts profile Also fetch family tagging data from a second Google Sheet (Submissions from designers via form: https://forms.gle/jcp3nDv63LaV1rxH6) (PR #4576)
|
Thanks for adding in a rationale. I'll make a point of doing this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Each family in the Google Fonts collection must have tagging data. We now have a form users can fill in to provide tags for their families, https://docs.google.com/forms/d/e/1FAIpQLScvQKapFIPcLezWbam1Os7OWWj90txJgXpvBRx7OQ3uHKzwLw/viewform. This form populates another sheet in the Google Sheet. This PR will fetch the data from the other sheet and combine it with the existing sheet.
Merging this PR will allow the following PRs to pass in google/fonts:
Checklist
CHANGELOG.md