-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of docker reference manual #625
Conversation
Docs for e6d7e56 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2477/docs/artifacts/html/index.html |
I just realized I missed an issue for the restorable app page, will push again soon. |
Docs for 093aef0 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2478/docs/artifacts/html/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
source/user-guide/containers-and-docker/multi-stage-container.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems great 🚀 . I just added a few nits.
Otherwise, /lgtm
Docs for 7fb9f5d are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2480/docs/artifacts/html/index.html |
Style guidelines applied. Semantic newlines applied to follow best practices and to assist with editing. Moved pages which serve more to guide than inform to a new section of the user guide, 'Containers and Docker'. Added the appropriate redirects, as well as updating landing/index pages as needed. Ran linter, linkcheck, and viewed rendered html. This commit addresses FFTK-2789 This commit applies to FFTK-988 Signed-off-by: Katrina Prosise <[email protected]>
7fb9f5d
to
d851dbb
Compare
Docs for d851dbb are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2481/docs/artifacts/html/index.html |
Style guidelines applied.
Semantic newlines applied to follow best practices and to assist with editing.
Moved pages which serve more to guide than inform to a new section of the user guide, 'Containers and Docker'. Added the appropriate redirects, as well as updating landing/index pages as needed.
Ran linter, linkcheck, and viewed rendered html.
This commit addresses FFTK-2789
This commit applies to FFTK-988
Readiness
Overview
A lot being updated here, including moving many pages to a new section of the User Guide. Happy to make further changes and consider all feedback!
Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."
make linkcheck
.-s, --signoff
).-S, --gpg-sign
).Comments
There may very well be things I missed, as big updates like this can be a bit overwhelming.