Provide a subtitle with actions when using lores #17223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stwlam
reviewed
Nov 19, 2024
stwlam
reviewed
Nov 19, 2024
| @@ -86,7 +86,7 @@ function escapeCheckContext<ItemType extends ItemPF2e<ActorPF2e>>( | |||
| ); | |||
|
|
|||
| if (highest) { | |||
| const { checkType, stat: slug, subtitle } = ActionMacroHelpers.resolveStat(highest.statistic.slug); | |||
| const { checkType, stat: slug, subtitle } = ActionMacroHelpers.resolveStat(highest.statistic.slug, opts.actor); | |||
There was a problem hiding this comment.
not sure how this is related?
There was a problem hiding this comment.
In order to get access to the skill label, I added the actor as an argument to ActionMacroHelpers.resolveStat(). This is the one other call site of this function.
Current it will show a subtitle like "Lie (PF2E.ActionsCheck.legal-lore)" when trying to use a skill that doesn't have a translation, which no lore will. Detect the lack of translation and fall back to the "PF2E.ActionsCheck.x" translation format using the label of the skill. This will result in "Lie (Legal Lore Check)" if the skill was labeled in that way.
xyzzy42
force-pushed
the
actions-with-lores-subtitle
branch
from
7353ad0 to
1840460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current it will show a subtitle like "Lie (PF2E.ActionsCheck.legal-lore)" when trying to use a skill that doesn't have a translation, which no lore will.
Detect the lack of translation and fall back to the "PF2E.ActionsCheck.x" translation format using the label of the skill. This will result in "Lie (Legal Lore Check)" if the skill was labeled in that way.