[Is a member of][User groups] 'Add' button functionality #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carma12
requested review from
pvoborni and
mreynolds389
and removed request for
pvoborni
The `User` data type needs the following parameters that will be managed in the 'Is a member of' section: - `memberof_group` - `memberof_netgroup` - `memberof_role` - `memberof_hbacrule` - `memberof_sudorule` - `memberof_subid` Signed-off-by: Carla Martinez <[email protected]>
As other components are using the `MemberOfTable` and `MemberOfToolbar` components, there are many dependencies to correct and adapt. The new `MemberOfTableNew` and `MemberOfToolbarNew` have been defined to be used when adapting the 'User groups' data only. The same has been done in the data types by creating a new `UserGroupNew` type that will be used later. The `normalizeString` utility function is meant to normalize LDAP values from `string[]` to `string`. Signed-off-by: Carla Martinez <[email protected]>
The dummy data must be replaced by the data from the API for the 'User groups' only. Signed-off-by: Carla Martinez <[email protected]>
carma12
force-pushed
the
member-of-user-groups-add
branch
from
2264e75 to
9618dde
Compare
The 'Add' button functionality allows to associate any user group's member to a given user. Signed-off-by: Carla Martinez <[email protected]>
carma12
force-pushed
the
member-of-user-groups-add
branch
from
9618dde to
8ceccd1
Compare
|
Closing this PR in favor of this one: #298 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Add' button functionality allows to associate any user group's member to a given user.
To ensure that an Alert component will be displayed after a new addition, a new interface
AlertObjecthas been created to refer to a givenalerts(defined asconst alerts = useAlerts()) that is passed through props to a children component.This PR depends on this one to be merged: #264