-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Is a member of] User groups sync data #293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carma12
changed the title
[WIP][Is a member of] User groups sync data
[Is a member of] User groups sync data
Feb 27, 2024
pvoborni
requested changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, comments added.
carma12
force-pushed
the
user-groups-sync-data-2
branch
from
March 1, 2024 09:59
602e588
to
c804280
Compare
@pvoborni - I have adapted the code based on your comments. |
The deprecated `UserGroup` data type should be renamed and the components that consumes it adapted to the new name. At the same time, a new `UserGroup` type should take the new values and be ready to be used. ```ts export interface UserGroup { cn: string; gidnumber: string; description: string; dn: string; } ``` Signed-off-by: Carla Martinez <[email protected]>
The `User` data type needs the following parameters to manage the 'Is a member of' data: ``` memberof_group: string[]; // multivalue memberof_subid?: string[]; // multivalue memberof_netgroup: string[]; // multivalue memberof_role: string[]; // multivalue memberof_hbacrule: string[]; // multivalue memberof_sudorule: string[]; // multivalue memberof_subid: string[]; // multivalue ``` Signed-off-by: Carla Martinez <[email protected]>
New endpoint to retrieve the list of uids and user groups should be created. The latter will be used in a custom hook that would retrieve all needed info related to the 'Is a member of' section. Signed-off-by: Carla Martinez <[email protected]> TEMP: usergroups endpoint and c.hook Signed-off-by: Carla Martinez <[email protected]>
The dummy data from the table must be replaced by the data from the API server. Signed-off-by: Carla Martinez <[email protected]>
carma12
force-pushed
the
user-groups-sync-data-2
branch
from
March 1, 2024 10:09
c804280
to
1f763ad
Compare
pvoborni
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'User groups' dummy data from the table has been synchronized using the real data from the API.