Workflow Editor Activity Bar

[ElectronicBlueberry]

This PR brings the activity bar to the workflow editor, providing various workflow-related activities and tools. Key changes and features include:

• Support for undo/redo stack UI.
• Add workflows activity item to explore in detail and select workflows to add/copy steps from.
• Redesign expandable tool attributes panel
• More logic and UI improvements

Screen.Recording.2024-11-15.at.19.35.34-2.mov

Chnages

• changes (undo redo stack ui)
• workflows (to insert like tools)

Ideas for additional activities, but unsure about:

• workflow specific utility tools
• workflow attributes
  this would free up the right panel to serve a single purpose
• step list
• subworkflows (in this workflow)
• invocations of this workflow
• run with simplified run form
• edit report

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. Open the worklfow editore and play around

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[ahmedhamidawan]

This might tie in nicely with the ideas in #18166?

[bgruening]

The first round of feedback:

• separate "inputs" from tools, inputs are imho equivalent to "Upload"
• An easy way to exit is missing imho, "save and exit" instead of "save" might be an option, especially since we now have the "changes" option
• if there are no "workflows" then a hint should be shown like "Here are all workflows listed that you can include as sub-workflows"
• Q: is it useful to list the self-workflow? Is that even possible to include them in a workflow? Recursion?
• Should Ctrl+S save the workflow?
• if you click on tools, the focus should be on the search-box

Thanks @ElectronicBlueberry!

[bgruening]

Thanks a lot, Laila. Here is a small review from Wolfgang and me from the Biohackathon:

• If I click tools, my cursor should be in the search field
• If I click on " Input dataset: Missing a label and annotation " in the best-practise panel, its not clear which node is selected and I should probably see the left-side panel?
• if I save the "changes" disappear, this makes somehow sense, but its a bit confusing as the "changes" panel is then empty. Should we indicate the "versions" also in the changes panel?
  • if we move the version into the "changes" panel we could rename "Attributes" to Description?
• I'm not convinced "auto-layout", "upgrade" and "download" deserves its own panel item
  • separate them with another horizontal bar?
  • should auto-layout be part of the "annotation toolbar"
• 1. make sure the left panel is not shown, 2) move some boxes, 3) click the arrows (upper, left corner) to revert changes -> the left panel will open, which I think is wrong
• should "Inputs" in the tool panel be its own activity bar item?
• Best Practices Review is not scrollable
• The Run option should be moved to just above Save&Exit
• Downloads triggers a "leave page" warning - but we do not leave the page
• we propose: tools, workflows on top, a horizontal bar and then the rest of the items which are more "metadata inspection items"
• auto-layout can not be undone

[ahmedhamidawan]

These are wonderful changes @ElectronicBlueberry !!

One minuscule thing I've noticed is this:
As soon as you click Create a new workflow, and you land on a fresh editor, if you click Run, this happens:

Screen.Recording.2024-11-13.at.3.45.34.PM.mov

An empty workflow is created, which i think it shouldn't since the button should maybe be disabled?

[davelopez]

I have played around with this and I love it!

Amazing work!

The tests would require some massaging to make them happy though... 😅

[itisAliRH]

The workflow bookmarking is broken and you can not unbookmark a workflow. So the API seems to be working fine but the client side is broken and needs to be fixed. I put the PR into a draft and working on it.

[itisAliRH]

@ElectronicBlueberry Great work, Laila!

I’ve played and reviewed it and have addressed some issues and also made some improvements.

Thank you so much!

[itisAliRH]

This changes also fixes errors like below in the activity bar:

[davelopez]

The remaining selenium failure seems related, I can reproduce it locally https://github.com/galaxyproject/galaxy/actions/runs/12020223847/job/33517490725?pr=18729#step:10:3171

I'll try to figure out what is the issue.

[davelopez]

I think I got it... pushing commit.

[dannon]

Good eye! This fixes it for me locally, too.

[dannon]

Argh; I should have adjusted the branch to 24.2 prior to merge. I'll manually merge this back and forward.