Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some additional checks/code to be added across all out of tree providers #599

Closed
2 tasks done
AxiomSamarth opened this issue Mar 30, 2021 · 5 comments · Fixed by gardener/machine-controller-manager-provider-azure#17, gardener/machine-controller-manager-provider-aws#30, gardener/machine-controller-manager-provider-openstack#19, gardener/machine-controller-manager-provider-alicloud#12 or gardener/machine-controller-manager-provider-gcp#16
Closed
2 tasks done

Some additional checks/code to be added across all out of tree providers #599

AxiomSamarth opened this issue Mar 30, 2021 · 5 comments · Fixed by gardener/machine-controller-manager-provider-azure#17, gardener/machine-controller-manager-provider-aws#30, gardener/machine-controller-manager-provider-openstack#19, gardener/machine-controller-manager-provider-alicloud#12 or gardener/machine-controller-manager-provider-gcp#16
Assignees
@AxiomSamarth
Labels
kind/enhancement Enhancement, improvement, extension

Comments

@AxiomSamarth
Copy link
Contributor

AxiomSamarth commented Mar 30, 2021 •
edited
Loading

What would you like to be added:
This is the list of items to be added to all out of tree providers

  • Check to validate if the MachineClass in the scope is the MachineClass for the corresponding cloud provider
  • The deployment YAMLs and MachineClass YAMLs in the example folder to be updated (with all the useful fields. For example - provider)

Why is this needed:
@AxiomSamarth AxiomSamarth added the kind/enhancement Enhancement, improvement, extension label Mar 30, 2021
@AxiomSamarth
Copy link
Contributor Author

/assign @AxiomSamarth

@AxiomSamarth
Copy link
Contributor Author

AxiomSamarth commented Apr 1, 2021 •
edited
Loading

Progress checklist

  • MCM-Provider-Azure with PR
  • MCM-Provider-AWS with PR
  • MCM-Provider-Openstack with PR
  • MCM-Provider-GCP with PR
  • MCM-Provider-Alicloud with PR
  • MCM-Provider-vSphere with PR
  • MCM-Provider-Yandex with PR

This was referenced Apr 5, 2021
Merged
Merged
Merged
Merged
@prashanth26
Copy link
Contributor

prashanth26 commented Apr 8, 2021 •
edited
Loading

/reopen to track other providers. Thanks for the quick fixes @AxiomSamarth

@gardener-robot gardener-robot reopened this Apr 8, 2021
@AxiomSamarth
Copy link
Contributor Author

/reopen to track other providers. Thanks for the quick fixes @AxiomSamarth

Oh sorry! I guess, my merge in the Azure OOT closed this issue too. Thanks for reopening Prashanth. A few more are yet to be done and shall be completed soon.

This was referenced Apr 9, 2021
Merged
Merged
Open
Merged
Merged
Merged
Merged
@AxiomSamarth
Copy link
Contributor Author

/reopen

@AxiomSamarth AxiomSamarth mentioned this issue Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AxiomSamarth AxiomSamarth

Labels
kind/enhancement Enhancement, improvement, extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add a check on provider of the machineclass in the driver methods gardener/machine-controller-manager-provider-azure
Added a provider check for the machine class in all the driver methods AxiomSamarth/machine-controller-manager-provider-aws
Add checks to verify the support for incoming machine class AxiomSamarth/machine-controller-manager-provider-openstack
Add a check to verify the support for the MachineClass in scope gardener/machine-controller-manager-provider-alicloud
Validate the support for the provider in the MachineClass AxiomSamarth/machine-controller-manager-provider-gcp
add a check to validate the provider in MachineClass gardener/machine-controller-manager-provider-vsphere
updated the provider name in the machine class template AxiomSamarth/gardener-extension-provider-vsphere
Updated the error codes gardener/machine-controller-manager-provider-vsphere
updated the error codes gardener/machine-controller-manager-provider-alicloud
add a checkon provider of the machineclass in the driver methods with proper error codes gardener/machine-controller-manager-provider-azure
3 participants
@AxiomSamarth @prashanth26 @gardener-robot