Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor gardener/[email protected] and add cluster-autoscaler options to machine deployment #902

Closed
wants to merge 2 commits into from

Conversation

aaronfern
Copy link
Contributor

How to categorize this PR?

/area auto-scaling
/kind enhancement
/platform aws

What this PR does / why we need it:
This PR does the following

  1. Vendor gardener/gardener:v1.91.0
  2. Adds cluster-autoscaler options for worker groups from workers to machine deployments. These options allow users to specify some cluster-autoscaler specific for worker groups

Which issue(s) this PR fixes:
Fixes partially gardener/autoscaler#240

Special notes for your reviewer:

Release note:

NodeGroupAutoscalingOptions can now be specified per worker group via the worker through the field `worker.spec.pools.clusterAutoscaler`

@aaronfern aaronfern requested review from a team as code owners March 28, 2024 07:47
@gardener-robot gardener-robot added area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 28, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 28, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 28, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 28, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 28, 2024
@shafeeqes
Copy link
Contributor

shafeeqes commented Mar 28, 2024

Hi @aaronfern, Would it be enough to have 3315a1a in #901 to close this PR in favour of it?

@aaronfern
Copy link
Contributor Author

Hey @shafeeqes
Yes, that should be fine. Thanks!
Can you please update the PR description and release notes of your PR to capture these changes?

@aaronfern
Copy link
Contributor Author

Closing this PR in favour of #901
/close

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 28, 2024
@shafeeqes
Copy link
Contributor

Hey @shafeeqes Yes, that should be fine. Thanks! Can you please update the PR description and release notes of your PR to capture these changes?

Done, PTAL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else platform/aws Amazon web services platform/infrastructure size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants