forked from kubernetes/autoscaler
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting options per worker group #240
Labels
exp/beginner
Issue that requires only basic skills
kind/discussion
Discussion (enaging others in deciding about multiple options)
kind/enhancement
Enhancement, improvement, extension
priority/2
Priority (lower number equals higher priority)
status/closed
Issue is closed (either delivered or triaged)
Comments
gardener-robot
added
kind/discussion
Discussion (enaging others in deciding about multiple options)
priority/3
Priority (lower number equals higher priority)
labels
Jun 28, 2023
himanshu-kun
added
priority/2
Priority (lower number equals higher priority)
and removed
priority/3
Priority (lower number equals higher priority)
labels
Oct 5, 2023
A few options were debated, and we finally decided to go with an approach that is similar to the one used by amazon ASG The following is a proposal of the solutiong/g changes:
g/extension changes:
autoscaler changes:
The other approached we discussed were the following:
/cc @timuthy for comments on the g/g changes |
aaronfern
changed the title
Allow setting options per node group
Allow setting options per worker group
Jan 25, 2024
This was referenced Apr 16, 2024
Merged
Merged
/close as all PRs are merged |
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exp/beginner
Issue that requires only basic skills
kind/discussion
Discussion (enaging others in deciding about multiple options)
kind/enhancement
Enhancement, improvement, extension
priority/2
Priority (lower number equals higher priority)
status/closed
Issue is closed (either delivered or triaged)
/kind discussion
/priority 3
What would you like to be added:
Autoscaler now supports configuring certain flags per worker group. Some example flags are:
This helps in more fine-grained control over a cluster and how autoscaler works for that cluster.
kubernetes#3583 -> upstream issue which introduced this
kubernetes#3789 -> PR with first implementations
With time, more and more options are being made configurable on worker group level , which makes it essential for gardener to also allow configuring them by our end-users.
Some issue which can be solved by this are:
#227 (by reducing
scale-down-unneeded-time
for the required nodegroup also)The change should require changes in shoot API also , some related discussions are already ongoing gardener/gardener#8142
Changes/PRs that need to be filed to close this story
MCD
and add them toNodeGroupAutoscalingOptions
> Add options toNodeGroupAutoscalingOptions
frommachineDeployment
annotations #257MCD
s with these node group specific values as annotationsgardener/[email protected]
, Upgradek8s.io/*
dependencies and controller-runtime gardener-extension-provider-aws#901Why is this needed:
For better configurability of gardener autoscaler
The text was updated successfully, but these errors were encountered: