Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options to NodeGroupAutoscalingOptions from machineDeployment annotations #257

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Add options to NodeGroupAutoscalingOptions from machineDeployment annotations #257

merged 4 commits into from
Dec 13, 2023

Conversation

aaronfern
Copy link

What this PR does / why we need it:
This PR updated the machineDeployment.GetOptions() method to read annotations form machineDeployments and populate node group values in its NodeGroupAutoscalingOptions struct

Which issue(s) this PR fixes:
Fixes partially #240

Special notes for your reviewer:

Release note:

Autoscaler will now add NodeGroupAutoscalingOptions to node groups from annotations present in its corresponding machineDeployments

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 16, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 16, 2023
@aaronfern aaronfern changed the title Add options to NodeGroupAutoscalingOptions from machineDeployment` annotations Add options to NodeGroupAutoscalingOptions from machineDeployment annotations Nov 17, 2023
@gardener-robot
Copy link

@unmarshall, @himanshu-kun, @rishabh-11 You have pull request review open invite, please check

rishabh-11
rishabh-11 requested changes Nov 22, 2023
View reviewed changes
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please address the review comments.

cluster-autoscaler/cloudprovider/mcm/mcm_manager.go Outdated Show resolved Hide resolved
cluster-autoscaler/cloudprovider/mcm/mcm_cloud_provider.go Outdated Show resolved Hide resolved
cluster-autoscaler/cloudprovider/mcm/mcm_cloud_provider.go Outdated Show resolved Hide resolved
cluster-autoscaler/cloudprovider/mcm/mcm_cloud_provider.go Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Nov 22, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 24, 2023
@rishabh-11 rishabh-11 self-assigned this Nov 28, 2023
rishabh-11
rishabh-11 requested changes Nov 29, 2023
View reviewed changes
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests for GetOptions.

cluster-autoscaler/cloudprovider/mcm/mcm_cloud_provider.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Nov 30, 2023
@gardener-robot
Copy link

@aaronfern You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Nov 30, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2023
@gardener-robot gardener-robot removed the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Nov 30, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2023
@aaronfern aaronfern force-pushed the nodegroupautoscalingoptions_annotations branch from b5e4337 to f642902 Compare November 30, 2023 08:26
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2023
rishabh-11
rishabh-11 approved these changes Dec 12, 2023
View reviewed changes
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/rebase Needs git rebase needs/review Needs review labels Dec 12, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 12, 2023
@rishabh-11 rishabh-11 merged commit 6005261 into gardener:machine-controller-manager-provider Dec 13, 2023
10 of 16 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 13, 2023
@aaronfern aaronfern mentioned this pull request Dec 14, 2023
Closed
9 tasks
@aaronfern aaronfern mentioned this pull request Feb 26, 2024
Merged
@aaronfern aaronfern mentioned this pull request Mar 28, 2024
Closed
@shafeeqes shafeeqes mentioned this pull request Mar 28, 2024
Merged
This was referenced Apr 16, 2024
Merged
Merged
Merged
@aaronfern aaronfern mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

@himanshu-kun himanshu-kun Awaiting requested review from himanshu-kun

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

Assignees

@rishabh-11 rishabh-11

@aaronfern aaronfern

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aaronfern @gardener-robot @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3