test: Make plugin test OS independant (#459)

api/api_test.go

@@ -177,6 +177,7 @@ func TestGetProxies(t *testing.T) {
 		Address: config.DefaultAddress,
 	}
 	client := network.NewClient(context.TODO(), clientConfig, zerolog.Logger{}, nil)
+	require.NotNil(t, client)
 	newPool := pool.NewPool(context.TODO(), 1)
 	assert.Nil(t, newPool.Put(client.ID, client))
 

cmd/cmd_helpers_test.go

@@ -2,8 +2,10 @@ package cmd
 
 import (
 	"bytes"
+	"fmt"
 	"os"
 	"path/filepath"
+	"runtime"
 
 	"github.com/spf13/cobra"
 )
@@ -24,7 +26,14 @@ func executeCommandC(root *cobra.Command, args ...string) (string, error) {
 // mustPullPlugin pulls the gatewayd-plugin-cache plugin and returns the path to the archive.
 func mustPullPlugin() (string, error) {
 	pluginURL := "github.com/gatewayd-io/[email protected]"
-	fileName := "./gatewayd-plugin-cache-linux-amd64-v0.2.10.tar.gz"
+
+	fileName := fmt.Sprintf(
+		"./gatewayd-plugin-cache-%s-%s-%s%s",
+		runtime.GOOS,
+		runtime.GOARCH,
+		"v0.2.10",
+		getFileExtension(),
+	)
 
 	if _, err := os.Stat(fileName); os.IsNotExist(err) {
 		_, err := executeCommandC(rootCmd, "plugin", "install", "--pull-only", pluginURL)

cmd/plugin_install_test.go

@@ -3,6 +3,7 @@ package cmd
 import (
 	"fmt"
 	"os"
+	"runtime"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -64,7 +65,7 @@ func Test_pluginInstallCmdAutomatedNoOverwrite(t *testing.T) {
 		rootCmd, "plugin", "install",
 		"-p", pluginTestConfigFile, "--update", "--backup", "--overwrite-config=false")
 	require.NoError(t, err, "plugin install should not return an error")
-	assert.Contains(t, output, "/gatewayd-plugin-cache-linux-amd64-")
+	assert.Contains(t, output, fmt.Sprintf("/gatewayd-plugin-cache-%s-%s-", runtime.GOOS, runtime.GOARCH))
 	assert.Contains(t, output, "/checksums.txt")
 	assert.Contains(t, output, "Download completed successfully")
 	assert.Contains(t, output, "Checksum verification passed")