Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package argument in manual search macro #271

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Fix package argument in manual search macro #271

merged 1 commit into from
Jul 5, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jul 3, 2022

🦟 Bug fix

Fixes gazebosim/gz-common#386 and typo from #255

Summary

The package argument to ign_manual_search / gz_manual_search is package in everywhere except two places where it is PACKAGE_NAME. I believe this typo is the cause of gazebosim/gz-common#386 and am testing this fix in gazebosim/gz-common#387

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested review from mxgrey and j-rivero as code owners July 3, 2022 07:23
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 3, 2022
This was referenced Jul 3, 2022
Merged
Closed
chapulina
chapulina approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch, nice catch and thanks for the fix!

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jul 5, 2022
@chapulina chapulina merged commit 963efe3 into main Jul 5, 2022
@chapulina chapulina deleted the ci_matching_branch/fix_manual_search branch July 5, 2022 16:44
@scpeters scpeters mentioned this pull request Jul 6, 2022
Merged
8 tasks
@mjcarroll mjcarroll mentioned this pull request Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @chapulina