Remove example_INSTALL_DIR from PREFIX_PATH on examples #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
azeey
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
The documentation for CMAKE_PREFIX_PATH says semicolon is the correct separator, so I'm not sure if the warning is coming from that. But I think it's fine to remove since CMAKE_INSTALL_PREFIX is set to ${example_INSTALL_DIR}, which should allow find_package to find things in there (see https://cmake.org/cmake/help/latest/variable/CMAKE_INSTALL_PREFIX.html)
scpeters
approved these changes
Apr 4, 2024
| @@ -88,7 +88,7 @@ foreach(example ${example_directories}) | |||
| # See alternate approach in a2113e0997c9 if this becomes too slow | |||
| BUILD_ALWAYS 1 | |||
| CMAKE_ARGS | |||
| "-DCMAKE_PREFIX_PATH=${FAKE_INSTALL_PREFIX};${example_INSTALL_DIR}" | |||
There was a problem hiding this comment.
this seems fine
the history of using two paths here goes back a long time (3ea5909), so if CI is happy with just FAKE_INSTALL_PREFIX, then that should be fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Remove the
example_INSTALL_DIRto be passed toCMAKE_PREFIX_PATHsince it is probably unused since the separator is wrong (semicolon instead of a colon). This triggered my attention since Noble has a warning with 3.28 CMake version.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.