Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example_INSTALL_DIR from PREFIX_PATH on examples #421

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Remove example_INSTALL_DIR from PREFIX_PATH on examples #421

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e165361
Remove example_INSTALL_DIR from PREFIX_PATH on examples
j-rivero Apr 4, 2024
79dbb8c
Merge branch 'gz-cmake3' into jrivero/fix_cmake_warn_noble
j-rivero Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ foreach(example ${example_directories})
# See alternate approach in a2113e0997c9 if this becomes too slow
BUILD_ALWAYS 1
CMAKE_ARGS
"-DCMAKE_PREFIX_PATH=${FAKE_INSTALL_PREFIX};${example_INSTALL_DIR}"
Copy link
Member

@scpeters scpeters Apr 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems fine

the history of using two paths here goes back a long time (3ea5909), so if CI is happy with just FAKE_INSTALL_PREFIX, then that should be fine

"-DCMAKE_PREFIX_PATH=${FAKE_INSTALL_PREFIX}"
"-DCMAKE_BUILD_TYPE=${build_type}"
"-DCMAKE_INSTALL_PREFIX=${example_INSTALL_DIR}"
TEST_COMMAND
Expand Down
Loading