Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix severity level of gzlog #635

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Fix severity level of gzlog #635

merged 2 commits into from
Sep 6, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 5, 2024

🦟 Bug fix

Fixes #632

Summary

The severity level of gzlog was incorrectly set to err. Changing this to trace solves two problems:

  1. The log message is now a lot less alarming
  2. When running gz sim -v4, this message is not shown on the console. It will only be logged to file. It does show up on the console if you run with -v5.

The second point is technically a behavior change since in Harmonic, regardless of the verbosity level, gzlog would never show up on the console. However, duplicating that behavior with the new Console implementation proved to be very complicated. So, I propose we change the meaning of gzlog to be equivalent to gztrace.


Note
We'll have to make new prereleases of all downstream libraries for this fix to propagate. I vote we just wait for the stable release.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from marcoag as a code owner September 5, 2024 23:02
@azeey azeey requested a review from iche033 September 5, 2024 23:03
@azeey azeey requested a review from caguero September 5, 2024 23:03
@iche033
Copy link
Contributor

iche033 commented Sep 6, 2024

The test failures look related, probably due to behavior change?

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey merged commit 0a4a80f into gazebosim:gz-common6 Sep 6, 2024
11 checks passed
@azeey azeey deleted the fix_gzlog branch September 6, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gzlog prints msgs as [error]
3 participants