Clean all ASAN reported memory problems (curl related) #416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The current ASAN build reports quite a few problems related to memory not being freed. I think that I've hunted mos of them if not all.
Although our Jenkins ASAN builds are not repotring failures from these kind of problems (need to solve gazebosim/gz-cmake#240) they are easy visible from the logs, see the failures for this branch before this PR in: https://build.osrfoundation.org/job/gz_fuel_tools-ci_asan-gz-fuel-tools9-jammy-amd64/31/consoleFull (grep by "LeakSanitizer: detected memory leaks").
If the PR is good and there are no more problems, this testing build should be clean: https://build.osrfoundation.org/job/_test_gz_fuel_tools-ci_asan-gz-fuel-tools9-jammy-amd64/2/consoleFull
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.