Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HIDE_SYMBOLS_BY_DEFAULT + patches #600

Closed
wants to merge 3 commits into from

Conversation

j-rivero
Copy link
Contributor

🎉 New feature

Part of gazebosim/gz-cmake#392 and gazebosim/gz-cmake#166.

Summary

The PR enables the HIDE_SYMBOLS_BY_DEFAULT option and patch the failures found during the build on Linux.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero j-rivero requested a review from jennuine as a code owner November 16, 2023 17:41
@j-rivero j-rivero changed the title Jrivero/fix visibility Enable HIDE_SYMBOLS_BY_DEFAULT + patches Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (352e726) 70.14% compared to head (8ce0780) 70.14%.

❗ Current head 8ce0780 differs from pull request most recent head 9ba8a3c. Consider uploading reports for the commit 9ba8a3c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #600   +/-   ##
=======================================
  Coverage   70.14%   70.14%           
=======================================
  Files          38       38           
  Lines        5343     5343           
=======================================
  Hits         3748     3748           
  Misses       1595     1595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-rivero
Copy link
Contributor Author

This is now disabled ignition_gui-ci-pr_any-homebrew-amd64, check gz_gui-ci-pr_any-homebrew-amd64

@mjcarroll
Copy link
Contributor

Some Qt/Windows interactions causing the build to fail:

C:\J\workspace\gz_gui-pr-win\ws\gz-gui\test\helpers\TestHelper.cc(25,1): warning C4273: 'gz::gui::TestHelper::TestHelper': inconsistent dll linkage [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]

C:\J\workspace\gz_gui-pr-win\ws\gz-gui\test\helpers\TestHelper.hh(44,11): message : see previous definition of '{ctor}' (compiling source file C:\J\workspace\gz_gui-pr-win\ws\gz-gui\test\helpers\TestHelper.cc) [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]

C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\moc_TestHelper.cpp(59,1): warning C4273: 'gz::gui::TestHelper::qt_static_metacall': inconsistent dll linkage [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]

C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\../../../../gz-gui/test/helpers/TestHelper.hh(41,3): message : see previous definition of 'qt_static_metacall' (compiling source file C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\moc_TestHelper.cpp) [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]

C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\moc_TestHelper.cpp(66,78): warning C4273: 'staticMetaObject': inconsistent dll linkage [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]

C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\../../../../gz-gui/test/helpers/TestHelper.hh(41,3): message : see previous definition of 'public: static QMetaObject const gz::gui::TestHelper::staticMetaObject' (compiling source file C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\moc_TestHelper.cpp) [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]

C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\moc_TestHelper.cpp(66,78): error C2491: 'gz::gui::TestHelper::staticMetaObject': definition of dllimport static data member not allowed [C:\J\workspace\gz_gui-pr-win\ws\build\gz-gui9\test\helpers\gz-gui9_test_helpers.vcxproj]

@j-rivero
Copy link
Contributor Author

Closing this one in favor of #601

@j-rivero j-rivero closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants