-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable HIDE_SYMBOLS_BY_DEFAULT + patches #600
Conversation
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 70.14% 70.14%
=======================================
Files 38 38
Lines 5343 5343
=======================================
Hits 3748 3748
Misses 1595 1595 ☔ View full report in Codecov by Sentry. |
This is now disabled |
Some Qt/Windows interactions causing the build to fail:
|
Closing this one in favor of #601 |
🎉 New feature
Part of gazebosim/gz-cmake#392 and gazebosim/gz-cmake#166.
Summary
The PR enables the
HIDE_SYMBOLS_BY_DEFAULT
option and patch the failures found during the build on Linux.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.