Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HIDE_SYMBOLS_BY_DEFAULT + patches #600

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ set(GZ_GUI_PLUGIN_INSTALL_DIR
#============================================================================
# Configure the build
#============================================================================
gz_configure_build(QUIT_IF_BUILD_ERRORS)
gz_configure_build(QUIT_IF_BUILD_ERRORS
HIDE_SYMBOLS_BY_DEFAULT)

#============================================================================
# gz command line support
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/image_display/ImageDisplay.hh
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ namespace gz::gui::plugins
/// \<topic\> : Set the topic to receive image messages.
/// \<topic_picker\> : Whether to show the topic picker, true by default. If
/// this is false, a \<topic\> must be specified.
class ImageDisplay_EXPORTS_API ImageDisplay : public Plugin
class GZ_GUI_VISIBLE ImageDisplay : public Plugin
{
Q_OBJECT

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/key_publisher/KeyPublisher.hh
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ namespace gz::gui::plugins
///
/// ## Configuration
/// This plugin doesn't accept any custom configuration.
class KeyPublisher_EXPORTS_API KeyPublisher : public gz::gui::Plugin
class GZ_GUI_VISIBLE KeyPublisher : public gz::gui::Plugin
{
Q_OBJECT

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/publisher/Publisher.hh
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ namespace gz::gui::plugins
///
/// ## Configuration
/// This plugin doesn't accept any custom configuration.
class Publisher_EXPORTS_API Publisher : public Plugin
class GZ_GUI_VISIBLE Publisher : public Plugin
{
Q_OBJECT

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/shutdown_button/ShutdownButton.hh
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
namespace gz::gui::plugins
{
/// \brief This plugin provides a shutdown button.
class ShutdownButton_EXPORTS_API ShutdownButton: public gz::gui::Plugin
class GZ_GUI_VISIBLE ShutdownButton: public gz::gui::Plugin
{
Q_OBJECT

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/teleop/Teleop.hh
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ namespace gz::gui::plugins
/// vehicle in the world.
/// ## Configuration
/// * `<topic>`: Topic to publish twist messages to.
class Teleop_EXPORTS_API Teleop : public Plugin
class GZ_GUI_VISIBLE Teleop : public Plugin
{
Q_OBJECT

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/topic_echo/TopicEcho.hh
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ namespace gz::gui::plugins
///
/// ## Configuration
/// This plugin doesn't accept any custom configuration.
class TopicEcho_EXPORTS_API TopicEcho : public Plugin
class GZ_GUI_VISIBLE TopicEcho : public Plugin
{
Q_OBJECT

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/topic_viewer/TopicViewer.hh
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ namespace gz::gui::plugins

/// \brief a Plugin to view the topics and their msgs & fields
/// Field's informations can be passed by dragging them via the UI
class TopicViewer_EXPORTS_API TopicViewer : public Plugin
class GZ_GUI_VISIBLE TopicViewer : public Plugin
{
Q_OBJECT

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/world_control/WorldControl.hh
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ namespace gz::gui::plugins
///
/// If no elements are filled for the plugin, both the play/pause and the
/// step buttons will be displayed.
class WorldControl_EXPORTS_API WorldControl: public gz::gui::Plugin
class GZ_GUI_VISIBLE WorldControl: public gz::gui::Plugin
{
Q_OBJECT

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/world_control/WorldControlEventListener.hh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ namespace gz::gui
/// \brief Helper class for testing listening to events emitted by the
/// WorldControl plugin. This is used for testing the event behavior of
/// the WorldControl plugin.
class WorldControlEventListener : public QObject
class GZ_GUI_VISIBLE WorldControlEventListener : public QObject
{
Q_OBJECT

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/world_stats/WorldStats.hh
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ namespace gz::gui::plugins
///
/// If no elements are filled for the plugin, all properties will be
/// displayed.
class WorldStats_EXPORTS_API WorldStats: public gz::gui::Plugin
class GZ_GUI_VISIBLE WorldStats: public gz::gui::Plugin
{
Q_OBJECT

Expand Down
2 changes: 1 addition & 1 deletion test/helpers/TestHelper.hh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ namespace gz
namespace gui
{
/// \brief
class TestHelper_EXPORTS_API TestHelper : public QObject
class GZ_GUI_VISIBLE TestHelper : public QObject
{
Q_OBJECT

Expand Down