Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Gazebo materials #2269

Merged
merged 21 commits into from
Jan 12, 2024
Merged

Support for Gazebo materials #2269

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4ca06fe
test script tag
quarkytale Dec 7, 2023
c6b08b8
add dark grey before creating component
quarkytale Dec 9, 2023
29dc2aa
material parser
quarkytale Dec 14, 2023
4d1b9c5
linters
quarkytale Dec 20, 2023
c165528
Update src/rendering/MaterialParser/MaterialParser.cc
quarkytale Dec 20, 2023
7e333f5
fix configLoader, material struct and feedback
quarkytale Dec 20, 2023
4158a72
default color and todos
quarkytale Dec 20, 2023
930e89f
install/load one file, range based loop, hardcode dependent solid colors
quarkytale Dec 21, 2023
ee844d9
fix install_dir property
quarkytale Dec 21, 2023
083c2dd
credits, initializing cleanup
quarkytale Dec 22, 2023
a83e86c
eof
quarkytale Dec 22, 2023
6941c1c
Merge branch 'gz-sim8' into quarkytale/material
quarkytale Dec 22, 2023
07415de
reformat
quarkytale Dec 27, 2023
f2e2f5f
add integration test
quarkytale Jan 1, 2024
7b08ebf
migration note
quarkytale Jan 2, 2024
7621715
intends, default case, invalid color
quarkytale Jan 4, 2024
26c61ca
optional materialValues, typo
quarkytale Jan 5, 2024
404ffef
feedback
quarkytale Jan 5, 2024
d768c85
size check
quarkytale Jan 9, 2024
ccad6bd
get color values
quarkytale Jan 10, 2024
5455d1e
migration doc update
quarkytale Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/SdfEntityCreator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,20 +814,20 @@
{
gzwarn << "Using an internal gazebo.material to parse "
<< scriptName << std::endl;
MaterialParser::MaterialValues parsed =
std::optional<MaterialParser::MaterialValues> parsed =
this->dataPtr->materialParser.GetMaterialValues(scriptName);

if(!parsed.ambient.has_value()) {
if(!parsed.has_value()) {
gzwarn << "Material " << scriptName <<
" not recognized, using default."<< std::endl;
" not recognized, using default." << std::endl;

Check warning on line 822 in src/SdfEntityCreator.cc

View check run for this annotation

Codecov / codecov/patch

src/SdfEntityCreator.cc#L821-L822 

Added lines #L821 - L822 were not covered by tests
}

visualMaterial.SetAmbient
quarkytale marked this conversation as resolved.
Show resolved Hide resolved
(parsed.ambient.value_or(visualMaterial.Ambient()));
(parsed->ambient.value_or(visualMaterial.Ambient()));
visualMaterial.SetDiffuse
(parsed.diffuse.value_or(visualMaterial.Diffuse()));
(parsed->diffuse.value_or(visualMaterial.Diffuse()));
visualMaterial.SetSpecular
(parsed.specular.value_or(visualMaterial.Specular()));
(parsed->specular.value_or(visualMaterial.Specular()));
}
}
this->dataPtr->ecm->CreateComponent(visualEntity,
Expand Down
2 changes: 1 addition & 1 deletion src/rendering/MaterialParser/MaterialParser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ void MaterialParser::Load()
}

/////////////////////////////////////////////////
MaterialParser::MaterialValues MaterialParser::GetMaterialValues(
std::optional<MaterialParser::MaterialValues> MaterialParser::GetMaterialValues(
const std::string& material)
{
MaterialValues values;
quarkytale marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
2 changes: 1 addition & 1 deletion src/rendering/MaterialParser/MaterialParser.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class MaterialParser

void Load();

MaterialValues GetMaterialValues(const std::string& material);
std::optional<MaterialValues> GetMaterialValues(const std::string& material);

private:
ConfigLoader configLoader;
Expand Down
2 changes: 1 addition & 1 deletion tutorials/migration_sdf.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ that worked on Gazebo classic may need more plugins on Gazebo.
## Materials

Gazebo does not support Ogre material files like Classic does, because Gazebo
Gazebo can be used with multiple rendering engines. For example, materials defined
can be used with multiple rendering engines. For example, materials defined
within a `<script>` aren't supported on Gazebo:

```
Expand Down
Loading