Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update camera sensors to use the //sensor/camera/pose sdf element. #2433

Closed
wants to merge 2 commits into from

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 5, 2024

🦟 Bug fix

Summary

Follow-up on #2425 (comment). This is a behavior change so targeting main. The camera sensors will now take into account the //sensor/camera/pose sdf element. I also added an entry to Migration guide.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mjcarroll as a code owner June 5, 2024 15:54
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Jun 5, 2024
Signed-off-by: Ian Chen <[email protected]>
@azeey
Copy link
Contributor

azeey commented Jun 5, 2024

The //sensor/camera/pose element seems redundant with //sensor/pose. If we don't have a good reason to keep it, maybe it can be deprecated and removed from the SDFormat spec.

@iche033
Copy link
Contributor Author

iche033 commented Jun 6, 2024

I'm in favor of deprecating and then removing the tag. Closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants