Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HIDE_SYMBOLS_BY_DEFAULT #115

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Nov 4, 2023

🎉 New feature

Part of testing gazebosim/gz-cmake#392

Summary

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <[email protected]>

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from azeey as a code owner November 4, 2023 00:17
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #115 (ef3cf88) into main (32e4019) will not change coverage.
The diff coverage is n/a.

❗ Current head ef3cf88 differs from pull request most recent head b908ca3. Consider uploading reports for the commit b908ca3 to get more accurate results

@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   80.11%   80.11%           
=======================================
  Files           8        8           
  Lines         342      342           
=======================================
  Hits          274      274           
  Misses         68       68           

@mjcarroll mjcarroll merged commit 7bc8a8c into main Nov 6, 2023
7 checks passed
@mjcarroll mjcarroll deleted the scpeters/hide_symbols_by_default branch November 6, 2023 19:13
@scpeters
Copy link
Member Author

scpeters commented Nov 6, 2023

rebuilding the nightly deb:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants