Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct shared orb version #127

Closed
wants to merge 2 commits into from
Closed

Conversation

yj-yan
Copy link
Contributor

@yj-yan yj-yan commented Aug 15, 2023

What this PR does / why we need it

Use OrbVersion for shared orb if it is set in the service. This is used to fix the problem that stencil-circleci changed the shared orb to devbase:local in devbase repo. I also updated the tests snapshots.

Jira ID

DT-3834

Notes for your reviewers

The OrbVersion in a new field in stencil module. This PR should be merged after the related change in stencil is merged.

@yj-yan yj-yan requested a review from a team as a code owner August 15, 2023 17:01
@swarmia
Copy link

swarmia bot commented Aug 15, 2023

Copy link
Contributor

@jaredallard jaredallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes because I rejected the upstream stencil PR that would implement this.

@yj-yan yj-yan closed this Aug 21, 2023
@malept malept deleted the yjyan/correct-orb-version branch November 7, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants