Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use OrbVersion for correct shared orb version #270

Closed
wants to merge 1 commit into from

Conversation

yj-yan
Copy link
Contributor

@yj-yan yj-yan commented Aug 15, 2023

What this PR does / why we need it

Add OrbVersion to get the shared orb version and pass to stencil-circleCI. This is used to fix the problem that stencil-circleci changed the shared orb to devbase:local in devbase repo.

Jira ID

DT-3834

Notes for your reviewers

The OrbVersion is only applied when it is set in the manifest.
Related change in stencil-circle:getoutreach/stencil-circleci#127

@yj-yan yj-yan requested a review from a team as a code owner August 15, 2023 16:59
@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for engineering-outreach-io-stencil canceled.

Name Link
🔨 Latest commit 893af44
🔍 Latest deploy log https://app.netlify.com/sites/engineering-outreach-io-stencil/deploys/64dbaf1e9857080008eb3cab

@swarmia
Copy link

swarmia bot commented Aug 15, 2023

Copy link
Contributor

@jaredallard jaredallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I don't think this PR makes a ton of sense as-is right now. If we set OrbVersion here, we're opening ourselves up to project-specific version information that doesn't really have anything to do with stencil modules (what happens when someone wants a custom docker image version, or some other artifact?).

I'd propose that we instead encapsulate any information that needs to be specific to a project into a native module instead, which is what was meant to introduce functionality like this!

@yj-yan
Copy link
Contributor Author

yj-yan commented Aug 21, 2023

Unfortunately, I don't think this PR makes a ton of sense as-is right now. If we set OrbVersion here, we're opening ourselves up to project-specific version information that doesn't really have anything to do with stencil modules (what happens when someone wants a custom docker image version, or some other artifact?).

I'd propose that we instead encapsulate any information that needs to be specific to a project into a native module instead, which is what was meant to introduce functionality like this!

Thanks for suggestion. I see the risk here... I will look into the way of using native module instead for implementation. Closing this PR for now.

@yj-yan yj-yan closed this Aug 21, 2023
@jaredallard jaredallard deleted the yjyan/use-orb-version branch November 15, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants