Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade go.uber.org/zap/exp to v0.3.0 (to fix dependabot upgrades) #3378

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

jefft0
Copy link
Contributor

@jefft0 jefft0 commented Dec 19, 2024

Dependabot PRs #3306 and #3343 want to (among other things) upgrade go.uber.org/zap/exp from v0.2.0 to v0.3.0 . This causes a nil pointer exception because of this code:

	return slog.New(zapslog.NewHandler(logger.Core(), nil))

The problem is that go.uber.org/zap/exp v0.2.0 has:

func NewHandler(core zapcore.Core, opts *HandlerOptions) *Handler

but v0.3.0 has:

func NewHandler(core zapcore.Core, opts ...HandlerOption) *Handler

Thus, it views the nil second argument as a nil HandlerOption. The fix is to simply remove the second argument in the call to NewHandler.

When this is merged, we can tell dependabot to rebase the original PRs and the CI tests should pass.

@jefft0 jefft0 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 19, 2024
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Dec 19, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 19, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: jefft0/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@jefft0 jefft0 force-pushed the chore/upgrade-to-zap/exp-3.0 branch from 366230d to 7590198 Compare December 19, 2024 16:55
@jefft0 jefft0 marked this pull request as ready for review December 19, 2024 17:00
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@thehowl thehowl merged commit 10db3b4 into gnolang:master Dec 20, 2024
55 checks passed
@jefft0 jefft0 deleted the chore/upgrade-to-zap/exp-3.0 branch December 20, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related review/triage-pending PRs opened by external contributors that are waiting for the 1st review
Projects
Development

Successfully merging this pull request may close these issues.

3 participants