chore: Upgrade go.uber.org/zap/exp to v0.3.0 (to fix dependabot upgrades) #3378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot PRs #3306 and #3343 want to (among other things) upgrade go.uber.org/zap/exp from v0.2.0 to v0.3.0 . This causes a nil pointer exception because of this code:
The problem is that go.uber.org/zap/exp v0.2.0 has:
but v0.3.0 has:
Thus, it views the nil second argument as a nil
HandlerOption
. The fix is to simply remove the second argument in the call toNewHandler
.When this is merged, we can tell dependabot to rebase the original PRs and the CI tests should pass.