Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Withdrawals #30

Closed
wants to merge 8 commits into from
Closed

Withdrawals #30

wants to merge 8 commits into from

Conversation

debjit-bw
Copy link
Member

adds test for withdrawals:

  • gets withdrawals root for a specific withdrawals list (from both reth and nethermind)
  • asserts equality

For reth, we first deploy the deposit contract address

@debjit-bw debjit-bw marked this pull request as ready for review November 11, 2024 17:59
@@ -0,0 +1,483 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding separate bash scripts for every test scales pretty bad. The scripts should result in producing a sequence of blocks from Nethermind with the engine API and then apply those blocks on Reth.

So you can have multiple generators, each generates a directory of block JSONs blocks_test_withdrawals_eip4895, then we have a script that you pass a blocks_ directory as argument and runs the test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a better idea, i will close both PRs and do this instead

let deposit_requests = parse_deposits_from_receipts(&chain_spec, receipts.iter().flatten())
.map_err(|err| PayloadBuilderError::Internal(RethError::Execution(err.into())))?;

println!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't merge this log

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, removing

@dapplion
Copy link
Member

dapplion commented Nov 19, 2024

Closing in favor of:

Adding separate bash scripts for every test scales pretty bad. The scripts should result in producing a sequence of blocks from Nethermind with the engine API and then apply those blocks on Reth.

So you can have multiple generators, each generates a directory of block JSONs blocks_test_withdrawals_eip4895, then we have a script that you pass a blocks_ directory as argument and runs the test.

@debjit-bw debjit-bw deleted the withdrawals branch December 5, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants