Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rr controller npe #872

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix rr controller npe #872

merged 1 commit into from
Oct 24, 2023

Conversation

qmhu
Copy link
Member

@qmhu qmhu commented Oct 24, 2023

What type of PR is this?

bugfix

What this PR does / why we need it:

fix one npe error

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions
Copy link
Contributor

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2023-10-24 12:00
Git Version: bb5c1e4

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-872-bb5c1e4 docker pull gocrane/crane-agent:pr-872-bb5c1e4
dashboard:pr-872-bb5c1e4 docker pull gocrane/dashboard:pr-872-bb5c1e4
metric-adapter:pr-872-bb5c1e4 docker pull gocrane/metric-adapter:pr-872-bb5c1e4
craned:pr-872-bb5c1e4 docker pull gocrane/craned:pr-872-bb5c1e4

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-872-bb5c1e4 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-872-bb5c1e4 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-872-bb5c1e4 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-872-bb5c1e4 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-872-bb5c1e4 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-872-bb5c1e4
dashboard:pr-872-bb5c1e4 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-872-bb5c1e4
metric-adapter:pr-872-bb5c1e4 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-872-bb5c1e4
craned:pr-872-bb5c1e4 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-872-bb5c1e4

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-872-bb5c1e4 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-872-bb5c1e4 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-872-bb5c1e4 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-872-bb5c1e4 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-872-bb5c1e4 docker pull ghcr.io/gocrane/crane/crane-agent:pr-872-bb5c1e4
dashboard:pr-872-bb5c1e4 docker pull ghcr.io/gocrane/crane/dashboard:pr-872-bb5c1e4
metric-adapter:pr-872-bb5c1e4 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-872-bb5c1e4
craned:pr-872-bb5c1e4 docker pull ghcr.io/gocrane/crane/craned:pr-872-bb5c1e4

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-872-bb5c1e4 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-872-bb5c1e4 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-872-bb5c1e4 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-872-bb5c1e4 crane/crane

@qmhu qmhu merged commit e29f4d6 into gocrane:main Oct 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant