Move Vec zero extension functions to FromZeros #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
from-zeros-extension-methods
branch
from
5c375be to
1811a94
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1690 +/- ##
==========================================
+ Coverage 88.01% 88.79% +0.77%
==========================================
Files 16 16
Lines 5805 5843 +38
==========================================
+ Hits 5109 5188 +79
+ Misses 696 655 -41 ☔ View full report in Codecov by Sentry. |
joshlf
force-pushed
the
from-zeros-extension-methods
branch
from
1811a94 to
36ac28a
Compare
While the ergonomics of calling these as associated functions on `FromZeros` is not as good as the ergonomics of them as bare functions, the discoverability is considerably higher.
joshlf
force-pushed
the
from-zeros-extension-methods
branch
from
36ac28a to
a537583
Compare
jswrenn
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the ergonomics of calling these as associated functions on
FromZerosis not as good as the ergonomics of them as bare functions, the discoverability is considerably higher.