Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update CONTRIBUTING.md to include conventional commit guidelines #1611

Closed
wants to merge 2 commits into from
Closed

docs: Update CONTRIBUTING.md to include conventional commit guidelines #1611

wants to merge 2 commits into from

Conversation

maitrimangal
Copy link
Member

@maitrimangal maitrimangal commented Jun 12, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1506

@maitrimangal maitrimangal requested review from a team as code owners June 12, 2023 21:37
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Jun 12, 2023
@maitrimangal maitrimangal mentioned this pull request Jun 12, 2023
Closed
4 tasks
@hannahrogers-google hannahrogers-google added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 12, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CONTRIBUTING.md] Add link to Conventional Commits
2 participants
@maitrimangal @hannahrogers-google