Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add name to query parameters for blob upload #761

Closed
wants to merge 11 commits into from
Closed

fix: add name to query parameters for blob upload #761

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b4146a9
fix: support setting STORAGE_EMULATOR_HOST without /storage/{version}…
jack-michaud Apr 6, 2022
bd075c8
fix: add name to query parameters for blob upload
jack-michaud Apr 8, 2022
667889a
Merge branch 'main' into jm/storage-emulator-support
jack-michaud Apr 11, 2022
922ba5d
fix: add name to resumable uploads
jack-michaud Apr 13, 2022
c787cd2
Merge branch 'main' of github.com:jack-michaud/python-storage into jm…
jack-michaud Apr 13, 2022
cf6580b
Merge branch 'main' of github.com:googleapis/python-storage into jm/s…
jack-michaud Apr 13, 2022
50ee10b
Merge branch 'jm/storage-emulator-support' of github.com:jack-michaud…
jack-michaud Apr 13, 2022
99e15b9
Revert "fix: support setting STORAGE_EMULATOR_HOST without /storage/{…
jack-michaud Apr 13, 2022
6858281
Merge branch 'main' of github.com:googleapis/python-storage into jm/s…
jack-michaud Apr 28, 2022
90495b5
Merge branch 'main' into jm/storage-emulator-support
jack-michaud Aug 3, 2022
0726258
Merge branch 'main' into jm/storage-emulator-support
jack-michaud Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions google/cloud/storage/blob.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1865,6 +1865,9 @@ def _do_multipart_upload(
if self.user_project is not None:
name_value_pairs.append(("userProject", self.user_project))

if self.name is not None:
name_value_pairs.append(("name", self.name))

# When a Customer Managed Encryption Key is used to encrypt Cloud Storage object
# at rest, object resource metadata will store the version of the Key Management
# Service cryptographic material. If a Blob instance with KMS Key metadata set is
Expand Down Expand Up @@ -2052,6 +2055,9 @@ def _initiate_resumable_upload(
if self.user_project is not None:
name_value_pairs.append(("userProject", self.user_project))

if self.name is not None:
name_value_pairs.append(("name", self.name))

# When a Customer Managed Encryption Key is used to encrypt Cloud Storage object
# at rest, object resource metadata will store the version of the Key Management
# Service cryptographic material. If a Blob instance with KMS Key metadata set is
Expand Down