Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add name to query parameters for blob upload #761

Closed

Conversation

jack-michaud
Copy link

Part of the fixes for #752.

The emulator expects a name query parameter for file uploads. The python client does not provide this; the URL looks like this:

/upload/storage/v1/b/redacted-bucket.appspot.com/o?uploadType=multipart

Adding this parameter fixes the issue; the URL now looks like this:

/upload/storage/v1/b/redacted-bucket.appspot.com/o?uploadType=multipart&name=storage_test%2Ftest.txt

Fixes #752 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/python-storage API. labels Apr 8, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Apr 13, 2022
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Apr 13, 2022
@jack-michaud jack-michaud marked this pull request as ready for review August 3, 2022 20:18
@jack-michaud jack-michaud requested review from a team as code owners August 3, 2022 20:18
@jack-michaud
Copy link
Author

Superceded by firebase/firebase-tools#4832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase Storage Emulator Support
1 participant