-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add name to query parameters for blob upload #761
Closed
jack-michaud
wants to merge
11
commits into
googleapis:main
from
jack-michaud:jm/storage-emulator-support
Closed
fix: add name to query parameters for blob upload #761
jack-michaud
wants to merge
11
commits into
googleapis:main
from
jack-michaud:jm/storage-emulator-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
Pull request size is extra small.
api: storage
Issues related to the googleapis/python-storage API.
labels
Apr 8, 2022
…/storage-emulator-support
…torage-emulator-support
…/python-storage into jm/storage-emulator-support
product-auto-label
bot
added
size: s
Pull request size is small.
and removed
size: xs
Pull request size is extra small.
labels
Apr 13, 2022
…version} suffix" This reverts commit b4146a9.
product-auto-label
bot
added
size: xs
Pull request size is extra small.
and removed
size: s
Pull request size is small.
labels
Apr 13, 2022
Superceded by firebase/firebase-tools#4832 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the googleapis/python-storage API.
size: xs
Pull request size is extra small.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fixes for #752.
The emulator expects a name query parameter for file uploads. The python client does not provide this; the URL looks like this:
Adding this parameter fixes the issue; the URL now looks like this:
Fixes #752 🦕