Fix linking issue with SUPERNODE_HTTP_TIMEOUT_MILLIS #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagerman
reviewed
Apr 27, 2019
| @@ -226,7 +226,7 @@ namespace nodetool | |||
| typename request_struct::response resp = AUTO_VAL_INIT(resp); | |||
| bool r = epee::net_utils::invoke_http_json(m_supernode_uri + uri, | |||
| req, resp, m_supernode_client, | |||
| std::chrono::milliseconds(SUPERNODE_HTTP_TIMEOUT_MILLIS), "POST"); | |||
| std::chrono::milliseconds(size_t(SUPERNODE_HTTP_TIMEOUT_MILLIS)), "POST"); | |||
There was a problem hiding this comment.
Perhaps you should actually fix the problem rather than hacking around it: you have a static constexpr variable without a definition, which isn't valid (until C++17).
There was a problem hiding this comment.
@jagerman Thank you for pointing us to this issue. Please feel free to provide correct fix as a separate PR.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.