Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking issue with SUPERNODE_HTTP_TIMEOUT_MILLIS #254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix linking issue with SUPERNODE_HTTP_TIMEOUT_MILLIS #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/p2p/net_node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ namespace nodetool
typename request_struct::response resp = AUTO_VAL_INIT(resp);
bool r = epee::net_utils::invoke_http_json(m_supernode_uri + uri,
req, resp, m_supernode_client,
std::chrono::milliseconds(SUPERNODE_HTTP_TIMEOUT_MILLIS), "POST");
std::chrono::milliseconds(size_t(SUPERNODE_HTTP_TIMEOUT_MILLIS)), "POST");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you should actually fix the problem rather than hacking around it: you have a static constexpr variable without a definition, which isn't valid (until C++17).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jagerman Thank you for pointing us to this issue. Please feel free to provide correct fix as a separate PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.learncpp.com/cpp-tutorial/811-static-member-variables/

if (!r || resp.status == 0)
{
return 0;
Expand Down