-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Github custom properties table to cloudquery #1338
Conversation
repository_id BigInt | ||
value String? | ||
|
||
@@ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! This means that it's ignored by the Prisma client (see docs). I added @@ignore
to this model, as we currently don't need it because we're not doing anything with the table in service catalogue. The model being the schema means that the table will be kept up to date nonentheless, IIUC. When we start to interact with the data via the Prisma client in future work, then we will stop ignoring it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. Thanks for the extra info!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we explicitly add this new table to the ones we're collecting?
What does this change?
github_repository_custom_properties
table in prisma schemaWhy?
This follows from #1316. Using custom properties will allow us to move away from topics. Custom properties can be
made compulsory, which means we can enforce repos to choose a property.
The
production
custom property also applies branch protection.How has it been verified?