Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p1: Add Gradle binary compatibility plugin #145

Merged
merged 54 commits into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
25b284c
Add gradle binary compatibility checker plugin
ab-gnm Dec 6, 2024
d68f673
Generate API dump for Source
ab-gnm Dec 6, 2024
f1c0686
Import `DensityExtensions` from news project
ab-gnm Dec 6, 2024
cd0c601
Create `ExpandingText` component
ab-gnm Dec 6, 2024
51be8f3
Add `SourceBaseChip`
ab-gnm Dec 6, 2024
d490089
Add `SourceChip` with text only
ab-gnm Dec 6, 2024
26c9007
Simplify `SourceBaseChip` to provide just a single `content` lambda
ab-gnm Dec 7, 2024
0c36ef5
Lint issues in build scripts
ab-gnm Dec 7, 2024
2ee1133
Remove inner text padding from `ExpandingText`
ab-gnm Dec 7, 2024
d58f631
Import marina_hyde.png cutout for previews
ab-gnm Dec 7, 2024
d33d2a7
Streamline styling of `SourceChip`
ab-gnm Dec 7, 2024
e7bca6b
Run lint in CI
ab-gnm Dec 7, 2024
7f757d3
Lint
ab-gnm Dec 7, 2024
81cc259
Extract `ChipIndicator` and provide variants for vector, painter, com…
ab-gnm Dec 7, 2024
aee0496
Add KDoc and preview for `ChipIndicator`
ab-gnm Dec 7, 2024
c2469c1
Update `HorizontalExpandingText` so it expands/collapses based on tex…
ab-gnm Dec 7, 2024
7bf5994
Use `HorizontalExpandingText` in `SourceChip`
ab-gnm Dec 7, 2024
deb9b60
Remove redundant label from manifest
ab-gnm Dec 7, 2024
ac62df5
Add screenshot test
ab-gnm Dec 7, 2024
4679eef
Separate style model for `SourceBaseChip`
ab-gnm Dec 7, 2024
d8b6fbb
Add selected state to `SourceChip`
ab-gnm Dec 7, 2024
2e1822b
Update screenshot test - remove tablet previews, add font scale previews
ab-gnm Dec 7, 2024
3968716
Add detekt baseline
ab-gnm Dec 7, 2024
20749ef
Lint
ab-gnm Dec 9, 2024
a5c49f1
Remove detekt convention plugin. Instead apply it to all module conve…
ab-gnm Dec 9, 2024
ee38878
Merge branch 'ab/change-detekt-config' into ab/add-chips-components
ab-gnm Dec 9, 2024
28e5587
Remove detekt convention plugin. Instead apply it to all module conve…
ab-gnm Dec 9, 2024
2101ef7
Merge branch 'ab/change-detekt-config' into ab/add-chips-components
ab-gnm Dec 9, 2024
7a458d3
Add detekt baseline
ab-gnm Dec 9, 2024
af173f1
Update lint baseline
ab-gnm Dec 9, 2024
0748699
Merge branch 'ab/change-detekt-config' into ab/add-chips-components
ab-gnm Dec 9, 2024
448bb21
Clean up previews, add dark mode support to screenshot test
ab-gnm Dec 9, 2024
959a75f
Baselines update
ab-gnm Dec 9, 2024
56a84fa
Add `SourceChipSupportingButton`
ab-gnm Dec 9, 2024
22f2d86
Move preview components inside package
ab-gnm Dec 9, 2024
6b1a416
Add preview to sample and clean up baseline
ab-gnm Dec 9, 2024
ee8ad1d
Make size mandatory in `SourceChipSupportingButton`
ab-gnm Dec 9, 2024
3f44b96
Split out single and multi select components as variants
ab-gnm Dec 9, 2024
d076255
Add README.md for chips
ab-gnm Dec 9, 2024
d813ae6
Split out `README.md` files for buttons and pager components as well
ab-gnm Dec 9, 2024
1ae8075
Update chips README.md
ab-gnm Dec 9, 2024
4bd3ef4
Formatting in README.md
ab-gnm Dec 9, 2024
1d44aca
Add example for version catalot
ab-gnm Dec 9, 2024
22eeeb2
Update minor version for addition of chips component
ab-gnm Dec 9, 2024
e24d0bb
Merge branch 'ab/add-chips-components' into ab/add-documentation
ab-gnm Dec 9, 2024
eb67513
Remove old `detekt-baseline-debug.xml`
ab-gnm Dec 9, 2024
1b70642
Merge branch 'ab/add-chips-components' into ab/add-documentation
ab-gnm Dec 9, 2024
75d603a
PR feedback driven changes:
ab-gnm Dec 10, 2024
697f2d5
Rename `ChipIndicator` to `ChipDecoration`
ab-gnm Dec 10, 2024
fd47629
Update baseline images
ab-gnm Dec 10, 2024
66e2e5f
Simplify table in KDoc
ab-gnm Dec 10, 2024
6a35af8
Merge pull request #149 from guardian/ab/add-documentation
ab-gnm Dec 12, 2024
62539e7
Merge pull request #148 from guardian/ab/change-detekt-config
ab-gnm Dec 12, 2024
13e0633
Merge pull request #146 from guardian/ab/add-chips-components
ab-gnm Dec 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions android/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ plugins {
alias(libs.plugins.nexus.publish)
alias(libs.plugins.compose.compiler) apply false
alias(libs.plugins.dokka) apply false
alias(libs.plugins.gradle.binaryCompatibility)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied directly to all modules (no apply false)

}

group = libs.versions.group.get()
Expand Down
3 changes: 3 additions & 0 deletions android/gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ lint-gradle = "1.0.0-alpha02"
nexus-publish = "2.0.0"
timber = "5.0.1"

gradle-binary-compatibility = "0.16.3"

junit = "4.13.2"
espressoCore = "3.6.1"
androidx-junit = "1.2.1"
Expand Down Expand Up @@ -95,6 +97,7 @@ kgp = { id = "org.jetbrains.kotlin.android", version.ref = "kotlin" }
kotlinter = { id = "org.jmailen.kotlinter", version.ref = "kotlinter" }
paparazzi = { id = "app.cash.paparazzi", version.ref = "paparazzi" }
dokka = { id = "org.jetbrains.dokka", version.ref = "dokka" }
gradle-binaryCompatibility = { id = "org.jetbrains.kotlinx.binary-compatibility-validator", version.ref = "gradle-binary-compatibility" }

nexus-publish = { id = "io.github.gradle-nexus.publish-plugin", version.ref = "nexus-publish" }

Expand Down
Loading
Loading