Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add probe override support #124

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

bvanleeuwen1995
Copy link
Contributor

Hi,

I just deployed Vaultwarden using chart, I configured Vaultwarden to run on non root path (/vaultwarden), this however causes the pod to be restarted since the chart deployment probe checks only /alive which needs to be /vaultwarden/alive in my case.

This chart fixes that problem and allows the probe URL to be set.

@guerzon
Copy link
Owner

guerzon commented Oct 28, 2024

Hi @bvanleeuwen-ndw, thanks for the PR. Please also bump the chart version. Thanks

@bvanleeuwen1995
Copy link
Contributor Author

Thank you for the quick response, do you want a path or minor bump?

@guerzon
Copy link
Owner

guerzon commented Oct 28, 2024

I would say a minor bump is fine.

@bvanleeuwen1995
Copy link
Contributor Author

Done :)

@guerzon guerzon merged commit 92a6d93 into guerzon:main Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants