Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add probe override support #124

Merged
merged 3 commits into from
Oct 29, 2024
+41 −29
Merged

Add probe override support #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e65107
Allow overriding of probe paths when not running on root path
bvanleeuwen-ndw Oct 28, 2024
a5bff2a
Update Readme file
bvanleeuwen-ndw Oct 28, 2024
8accf61
Update version tag
bvanleeuwen-ndw Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/vaultwarden/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ maintainers:
- name: guerzon
email: [email protected]
url: https://github.com/guerzon
version: 0.29.2
version: 0.29.3
kubeVersion: ">=1.12.0-0"
53 changes: 28 additions & 25 deletions charts/vaultwarden/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,31 +344,34 @@ helm -n $NAMESPACE uninstall $RELEASE_NAME

### Reliability configuration

| Name | Description | Value |
| ------------------------------------ | ----------------------------------------------------------------------- | ------- |
| `livenessProbe.enabled` | Enable liveness probe | `true` |
| `livenessProbe.initialDelaySeconds` | Delay before liveness probe is initiated | `5` |
| `livenessProbe.timeoutSeconds` | How long to wait for the probe to succeed | `1` |
| `livenessProbe.periodSeconds` | How often to perform the probe | `10` |
| `livenessProbe.successThreshold` | Minimum consecutive successes for the probe to be considered successful | `1` |
| `livenessProbe.failureThreshold` | Minimum consecutive failures for the probe to be considered failed | `10` |
| `readinessProbe.enabled` | Enable readiness probe | `true` |
| `readinessProbe.initialDelaySeconds` | Delay before readiness probe is initiated | `5` |
| `readinessProbe.timeoutSeconds` | How long to wait for the probe to succeed | `1` |
| `readinessProbe.periodSeconds` | How often to perform the probe | `10` |
| `readinessProbe.successThreshold` | Minimum consecutive successes for the probe to be considered successful | `1` |
| `readinessProbe.failureThreshold` | Minimum consecutive failures for the probe to be considered failed | `3` |
| `startupProbe.enabled` | Enable startup probe | `false` |
| `startupProbe.initialDelaySeconds` | Delay before startup probe is initiated | `5` |
| `startupProbe.timeoutSeconds` | How long to wait for the probe to succeed | `1` |
| `startupProbe.periodSeconds` | How often to perform the probe | `10` |
| `startupProbe.successThreshold` | Minimum consecutive successes for the probe to be considered successful | `1` |
| `startupProbe.failureThreshold` | Minimum consecutive failures for the probe to be considered failed | `10` |
| `resources` | Resource configurations | `{}` |
| `strategy` | Resource configurations | `{}` |
| `podDisruptionBudget.enabled` | Enable PodDisruptionBudget settings | `false` |
| `podDisruptionBudget.minAvailable` | Minimum number/percentage of pods that should remain scheduled. | `1` |
| `podDisruptionBudget.maxUnavailable` | Maximum number/percentage of pods that may be made unavailable | `nil` |
| Name | Description | Value |
|--------------------------------------|---------------------------------------------------------------------------|----------|
| `livenessProbe.enabled` | Enable liveness probe | `true` |
| `livenessProbe.initialDelaySeconds` | Delay before liveness probe is initiated | `5` |
| `livenessProbe.timeoutSeconds` | How long to wait for the probe to succeed | `1` |
| `livenessProbe.periodSeconds` | How often to perform the probe | `10` |
| `livenessProbe.successThreshold` | Minimum consecutive successes for the probe to be considered successful | `1` |
| `livenessProbe.failureThreshold` | Minimum consecutive failures for the probe to be considered failed | `10` |
| `livenessProbe.path` | Path which probe tries to resolve, override when non-root path deployment | `/alive` |
| `readinessProbe.enabled` | Enable readiness probe | `true` |
| `readinessProbe.initialDelaySeconds` | Delay before readiness probe is initiated | `5` |
| `readinessProbe.timeoutSeconds` | How long to wait for the probe to succeed | `1` |
| `readinessProbe.periodSeconds` | How often to perform the probe | `10` |
| `readinessProbe.successThreshold` | Minimum consecutive successes for the probe to be considered successful | `1` |
| `readinessProbe.failureThreshold` | Minimum consecutive failures for the probe to be considered failed | `3` |
| `readinessProbe.path` | Path which probe tries to resolve, override when non-root path deployment | `/alive` |
| `startupProbe.enabled` | Enable startup probe | `false` |
| `startupProbe.initialDelaySeconds` | Delay before startup probe is initiated | `5` |
| `startupProbe.timeoutSeconds` | How long to wait for the probe to succeed | `1` |
| `startupProbe.periodSeconds` | How often to perform the probe | `10` |
| `startupProbe.successThreshold` | Minimum consecutive successes for the probe to be considered successful | `1` |
| `startupProbe.failureThreshold` | Minimum consecutive failures for the probe to be considered failed | `10` |
| `startupProbe.path` | Path which probe tries to resolve, override when non-root path deployment | `/alive` |
| `resources` | Resource configurations | `{}` |
| `strategy` | Resource configurations | `{}` |
| `podDisruptionBudget.enabled` | Enable PodDisruptionBudget settings | `false` |
| `podDisruptionBudget.minAvailable` | Minimum number/percentage of pods that should remain scheduled. | `1` |
| `podDisruptionBudget.maxUnavailable` | Maximum number/percentage of pods that may be made unavailable | `nil` |

### Persistent data configuration

Expand Down
6 changes: 3 additions & 3 deletions charts/vaultwarden/templates/_podSpec.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ containers:
{{- if .Values.livenessProbe.enabled }}
livenessProbe:
httpGet:
path: /alive
path: {{ .Values.livenessProbe.path }}
port: http
initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.livenessProbe.periodSeconds }}
Expand All @@ -149,7 +149,7 @@ containers:
{{- if .Values.readinessProbe.enabled }}
readinessProbe:
httpGet:
path: /alive
path: {{ .Values.readinessProbe.path }}
port: http
initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.readinessProbe.periodSeconds }}
Expand All @@ -160,7 +160,7 @@ containers:
{{- if .Values.startupProbe.enabled }}
startupProbe:
httpGet:
path: /alive
path: {{ .Values.startupProbe.path }}
port: http
initialDelaySeconds: {{ .Values.startupProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.startupProbe.periodSeconds }}
Expand Down
9 changes: 9 additions & 0 deletions charts/vaultwarden/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,9 @@ livenessProbe:
## @param livenessProbe.failureThreshold Minimum consecutive failures for the probe to be considered failed
##
failureThreshold: 10
## @param livenessProbe.path Path on which the probe is exposed, default is "/alive". Replace when using non-root path deployment
##
path: /alive

## Readiness probe configuration
##
Expand All @@ -175,6 +178,9 @@ readinessProbe:
## @param readinessProbe.failureThreshold Minimum consecutive failures for the probe to be considered failed
##
failureThreshold: 3
## @param readinessProbe.path Path on which the probe is exposed, default is "/alive". Replace when using non-root path deployment
##
path: /alive

## Startup probe configuration
##
Expand All @@ -197,6 +203,9 @@ startupProbe:
## @param startupProbe.failureThreshold Minimum consecutive failures for the probe to be considered failed
##
failureThreshold: 10
## @param startupProbe.path Path on which the probe is exposed, default is "/alive". Replace when using non-root path deployment
##
path: /alive

## @param resources Resource configurations
##
Expand Down
Loading