Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(book): architecture of hax #1120

Merged
merged 6 commits into from
Dec 3, 2024
Merged

doc(book): architecture of hax #1120

merged 6 commits into from
Dec 3, 2024

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Nov 18, 2024

This PR adds a page to the book, documenting the high-level architecture of hax.

Fixes #752

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Generally looks good with a couple nits.

book/src/contributing/architecture.md Show resolved Hide resolved
book/src/contributing/architecture.md Outdated Show resolved Hide resolved
book/src/contributing/architecture.md Outdated Show resolved Hide resolved
book/src/contributing/architecture.md Show resolved Hide resolved
book/src/contributing/architecture.md Show resolved Hide resolved
book/src/contributing/architecture.md Outdated Show resolved Hide resolved
book/src/contributing/architecture.md Outdated Show resolved Hide resolved
book/src/contributing/architecture.md Outdated Show resolved Hide resolved
book/src/contributing/architecture.md Outdated Show resolved Hide resolved
@W95Psp W95Psp mentioned this pull request Nov 27, 2024
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there code changes in here now?

book/src/contributing/architecture.md Show resolved Hide resolved
book/src/contributing/architecture.md Show resolved Hide resolved
book/src/contributing/architecture.md Show resolved Hide resolved
@W95Psp W95Psp force-pushed the doc-architecture-hax branch from 45ea1db to 2586158 Compare November 28, 2024 07:14
@W95Psp W95Psp force-pushed the doc-architecture-hax branch from 2586158 to afff4b3 Compare November 28, 2024 07:16
@W95Psp
Copy link
Collaborator Author

W95Psp commented Nov 28, 2024

Huh, sorry, while doing something else I messed with this branch (I think I rebased that branch with a local main behind origin)... that thing is fixed now

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all comments resolved, yet, but generally lgtm. Please file follow ups for the ones you don't want to address here.

book/src/contributing/architecture.md Show resolved Hide resolved
@W95Psp W95Psp added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 9bfb646 Dec 3, 2024
15 checks passed
@W95Psp W95Psp deleted the doc-architecture-hax branch December 3, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Book: document the architecture of hax
2 participants