Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ProVerif] Renaming / AST transformation pseudophase #728

Closed
wants to merge 5 commits into from
Closed

[ProVerif] Renaming / AST transformation pseudophase #728

wants to merge 5 commits into from

Conversation

jschneider-bensch
Copy link
Collaborator

This PR introduces a pseudo-phase in the ProVerif backend that uses a visitor to perform renamings and last minute AST transformations like simplifying a Result<T,E> into a T.

@franziskuskiefer franziskuskiefer added the waiting-on-author Status: This is awaiting some action from the author. label Jun 21, 2024
@W95Psp W95Psp force-pushed the refactor-concrete-ident-generated branch from 2d680cb to e49233f Compare June 24, 2024 08:36
@jschneider-bensch jschneider-bensch mentioned this pull request Jul 1, 2024
Merged
@W95Psp W95Psp force-pushed the refactor-concrete-ident-generated branch 2 times, most recently from cc4d0cb to d7cdcc8 Compare July 1, 2024 11:31
Base automatically changed from refactor-concrete-ident-generated to main July 1, 2024 12:03
@github-actions GitHub Actions
Copy link

This PR has been marked as stale due to a lack of activity for 60 days. If you believe this pull request is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Aug 31, 2024
@github-actions github-actions bot removed the stale label Sep 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024

This PR has been marked as stale due to a lack of activity for 60 days. If you believe this pull request is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Nov 2, 2024
@github-actions GitHub Actions
Copy link

This PR has been closed due to a lack of activity since being marked as stale. If you believe this pull request is still relevant, please reopen it with an update or comment.

@github-actions github-actions bot closed this Nov 10, 2024
@jschneider-bensch jschneider-bensch self-assigned this Nov 18, 2024
@jschneider-bensch
Copy link
Collaborator Author

While Results were and are rewritten as stated above before, the contribution of this PR is putting all that in one place instead of having it distributed all over the backend in different places. It needs some cleanup, but would still be good. Re-opening.

@github-actions github-actions bot removed the stale label Nov 19, 2024
@franziskuskiefer
Copy link
Member

Let's close this and do this as part of the move to the generic printer in #745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jschneider-bensch jschneider-bensch

Labels
waiting-on-author Status: This is awaiting some action from the author.
Projects
No open projects
hax
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschneider-bensch @franziskuskiefer