Skip to content

Commit

Permalink
#1119 Make ENTER and OSC/keyboard slot trigger act just like normal t…
Browse files Browse the repository at this point in the history
…riggering
  • Loading branch information
helgoboss committed Aug 27, 2024
1 parent 2265230 commit 0e01432
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions main/src/domain/targets/playtime_slot_transport_target.rs
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ mod playtime_impl {
// This action is special in that it some of it can be carried out directly in the real-time
// thread **but not everything**! Other parts can only be done from main thread, such as
// starting to record into an empty slot and/or auto-activating the triggered slot. The
// stuff done in the main thread (play/stop) must NOT be repeated here.
// stuff done in the real-time thread (play/stop) must NOT be repeated here.
let velocity = value.to_unit_value().map_err(anyhow::Error::msg)?;
matrix.trigger_slot(
self.basics.slot_address,
Expand All @@ -163,7 +163,8 @@ mod playtime_impl {
.options
.stop_column_if_slot_empty,
allow_activate: true,
// If control was initiated from real-time target, don't take care of starting/stopping.
// If control was initiated from real-time context (MIDI), don't take care of
// starting/stopping. Because it's done in the real-time matrix already.
allow_start_stop: !context.coming_from_real_time,
},
)?;
Expand Down
2 changes: 1 addition & 1 deletion playtime-clip-engine

0 comments on commit 0e01432

Please sign in to comment.