chore: add backports to 0.4000.0 rc.3 #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add skip_config_check global flag to scaffolding * Prefer not writing the scaffold config for nixified custom templates * Fix rustfmt warning
* Remove dependency to holochain * Add rust-cache * Add cachix nix config * Add ci job concurrency options * Update cachix configurations * Run rust checks/tests outside nix * add missing components * Cache rust builds * Bump holochain deps * Update rustdocs * Build cargo deps separately * refactor flake * Update maintenance docs * Add extraPullNames input to cachix actions * Add nix_build step * Extend extra-substituters and public-keys in nixConfig * Fix ci workflow * Bump client-js version
* Fix misplaced doc comments * Slightly refactor link_type integrity codegen
* feat: Add a new template subcommand to create new custom template bases from existing templates * Remove call to wrapCustoTemplate in scaffolding nix flake * Update custom template docs
* Bump holochain playground * Update ui core dependencies * Update lit dependencies * Fix cli output lines * Fix broken css import in lit template * Revert custom-template changes * Fix vue templates * Increase testTimeout * Remove eslint from lit template * Fix lit CI failure * Add missing shared styles
…on-0.4 chore: backport svelte race condition to 0.4 and release 0.4000.0-rc.1
* Add go back functionality for hc scaffold entry-type * address PR comments * Ensure the fields vec is not empty on change * Improve text spacing * Simplify prompt
matthme
approved these changes
Dec 11, 2024
pdaoust
requested changes
Dec 11, 2024
| - Version bumps for `flake.nix`, `flake.lock` and `Cargo.lock` files should target the maintenance branches directly. | ||
| - Version bumps for dependencies of Scaffolding in the `Cargo.toml`. For dependencies that are still on the same version as on `develop` it would be valid to target `develop` and back-port but you'll end up with a tricky lock file merge anyway. | ||
| - Version bumps to Scaffolding itself don't make sense on `develop` so they should be made directly on the maintenance branches. | ||
| - Bug fixes that are specific to a particular version of Holochain. This should be rare, but if Holochain were to introduce an API change between 0.1.x and 0.1.x+1 but NOT make that change for Holochain 0.2.x then the PR for Scaffolding would target `develop-0.1` directly. |
There was a problem hiding this comment.
Curious if these extra two spaces in these three bullet points are accidental?
There was a problem hiding this comment.
This is my editor that did the formatting for me. Can fix this with a separate PR since this is an upstream change from develop
| @@ -97,10 +97,19 @@ | |||
| //! To create a custom template, execute these steps: | |||
| //! | |||
| //! 1. Run this command: | |||
There was a problem hiding this comment.
This is such good info to have. One thing that I don't understand is what does hc scaffold template clone do? Would it be worth mentioning it here?
There was a problem hiding this comment.
hc scaffold template clone will create a template from the current template you are using, pretty meta but this was how it was originally defined
pdaoust
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mirror of #410.
Significant backports include:
vite-plugin-sveltedependency by Revert update to vite-plugin-svelte for 0.4 #431holochainas a scaffolding dependencyAdditional fixe