Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the CheckBioauthTx #1366

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Refactor the CheckBioauthTx #1366

merged 2 commits into from
Dec 12, 2024

Conversation

MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Dec 12, 2024

This PR addresses the issue we've discovered during the code review with the too restrictive validation for the pallet bioauth extrinsics for the calls other than authenticate.

@MOZGIII MOZGIII changed the title bioauth validity check fix Refactor the CheckBioauthTx Dec 12, 2024
@MOZGIII MOZGIII force-pushed the bioauth-validity-check-fix branch from 573c6d4 to bbb4613 Compare December 12, 2024 12:38
@MOZGIII MOZGIII changed the base branch from master to bioauth-comment-fix December 12, 2024 12:38
Copy link
Contributor

@dmitrylavrenov dmitrylavrenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from bioauth-comment-fix to master December 12, 2024 13:00
Copy link
Contributor

@quasiyoke quasiyoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MOZGIII MOZGIII force-pushed the bioauth-validity-check-fix branch from bb9fbc5 to b660297 Compare December 12, 2024 13:15
@MOZGIII MOZGIII added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit fa28a30 Dec 12, 2024
21 checks passed
@MOZGIII MOZGIII deleted the bioauth-validity-check-fix branch December 12, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants