Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle nulls in ExtractPolygonsFromElements #161

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

handle nulls in ExtractPolygonsFromElements #161

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0724246
handle nulls in ExtractPolygonsFromElements - some roof elements had …
jamesbradleym Jan 5, 2024
262b6c3
remove unused warning array
jamesbradleym Jan 11, 2024
6ab109b
Merge branch 'master' into grid-null-handling
jamesbradleym Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions Grids/Grid/src/Grid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,22 @@
/// If this returns null, we'll use the 2D convex hull of the geometry of the element's representation </param>
private static List<Polygon> ExtractPolygonsFromElements<T>(IEnumerable<T> elements, Func<T, Polygon> getDefaultPolygon) where T : GeometricElement
{
List<string> warnings = new List<string>();

var polygons = new List<Polygon>();
foreach (var element in elements)
{
var polygon = getDefaultPolygon(element) ?? ConvexHull.FromPoints(element.Representation.SolidOperations.SelectMany(o => o.Solid.Vertices.Select(v => new Vector3(v.Value.Point.X, v.Value.Point.Y))));
polygons.Add(polygon);
var polygon = getDefaultPolygon(element) ??
ConvexHull.FromPoints(
element?.Representation?.SolidOperations?
.SelectMany(o => o?.Solid?.Vertices?
.Select(v => new Vector3(v.Value.Point.X, v.Value.Point.Y)) ?? Enumerable.Empty<Vector3>())
.Where(v => v != null)

Check warning on line 101 in Grids/Grid/src/Grid.cs

View workflow job for this annotation

GitHub Actions / build 

The result of the expression is always 'true' since a value of type 'Vector3' is never equal to 'null' of type 'Vector3?'

Check warning on line 101 in Grids/Grid/src/Grid.cs

View workflow job for this annotation

GitHub Actions / build 

The result of the expression is always 'true' since a value of type 'Vector3' is never equal to 'null' of type 'Vector3?'
);
if (polygon != null)
{
polygons.Add(polygon);
}
}
return polygons;
}
Expand Down
Loading