Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:add forge tests for TestSendReceiver #3055

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

aroralanuk
Copy link
Contributor

Description

  • Added TestSendReceiverTest after having removed testSendReceiver.hardhat-test.ts
    (latter uses blockhash randomness and can fail in CI infrequently but very frustratingly whereas the former is fuzzed and conditionally checked)

Drive-by changes

None

Related issues

None

Backward compatibility

Yes

Testing

Fuzz tests

Copy link

changeset-bot bot commented Dec 13, 2023

⚠️ No Changeset found

Latest commit: 93182e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
cc @tkporter

@aroralanuk aroralanuk merged commit cbea290 into main Dec 14, 2023
14 of 18 checks passed
@aroralanuk aroralanuk deleted the kunal/send-receiver-forge-test branch December 14, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants