Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #2373: kagami swarm file and kagami swarm dir #3585

Merged
merged 6 commits into from
Jun 29, 2023

Conversation

0x009922
Copy link
Contributor

@0x009922 0x009922 commented Jun 8, 2023

Description

#3475 introduces kagami swarm command, but it works only in directory mode. Now it is possible to produce both a "battery-included" directory and just a single file. The latter usage is especially helpful to generate sample docker-compose configurations to store them in the repo (docker-compose.yml, docker-compose.single.yml etc):

# only `docker-compose.yml`
kagami swarm file ./docker-compose.yml --build . --config-dir ./configs/peer --p 4 --seed "Kagami"

# a whole directory `test-swarm`
kagami swarm dir ./test-swarm --build . -p 4 --seed "Kagami"

Linked issue

Closes #2373

Benefits

We can automatise Docker Compose configurations generation and avoid problems with having outdated files in the repo. It will help the community.

Checklist

  • Remove --outfile and --outdir options, use positionals instead
  • Create an issue to include compose files generation into CI
  • Self-review

@0x009922 0x009922 added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Jun 8, 2023
@0x009922 0x009922 self-assigned this Jun 8, 2023
@0x009922 0x009922 force-pushed the swarm-single-file-emit branch from 40e5ba7 to cb84ce8 Compare June 8, 2023 03:40
@0x009922 0x009922 marked this pull request as ready for review June 8, 2023 03:45
@appetrosyan
Copy link
Contributor

I don't think this PR has the right target. We should merge into iroha2-dev most of the time,

@ilchu ilchu self-assigned this Jun 8, 2023
Base automatically changed from 2373-swarm to iroha2-dev June 8, 2023 08:10
@0x009922 0x009922 force-pushed the swarm-single-file-emit branch from cb84ce8 to 16425cc Compare June 8, 2023 08:14
@0x009922
Copy link
Contributor Author

0x009922 commented Jun 8, 2023

I don't think this PR has the right target. We should merge into iroha2-dev most of the time,

ATM of the PR creation, it was a direct successor of 2373-swarm branch, so I though it doesn't make sense to specify iroha2-dev as a target. Now with that PR being merged, the target has changed automatically.

appetrosyan
appetrosyan previously approved these changes Jun 20, 2023
tools/kagami/src/swarm.rs Show resolved Hide resolved
@appetrosyan appetrosyan force-pushed the swarm-single-file-emit branch from 5e86a1a to 9b5f229 Compare June 20, 2023 07:45
ilchu
ilchu previously approved these changes Jun 21, 2023
tools/kagami/src/swarm.rs Show resolved Hide resolved
appetrosyan
appetrosyan previously approved these changes Jun 26, 2023
@0x009922 0x009922 mentioned this pull request Jun 26, 2023
5 tasks
@0x009922 0x009922 force-pushed the swarm-single-file-emit branch from f8a9de6 to 253bae2 Compare June 27, 2023 00:09
0x009922 and others added 6 commits June 28, 2023 16:59
Signed-off-by: Dmitry Balashov <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
Co-authored-by: Aleksandr Petrosyan <[email protected]>
Signed-off-by: 0x009922 <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
@0x009922 0x009922 force-pushed the swarm-single-file-emit branch from 253bae2 to e8124de Compare June 28, 2023 09:59
@appetrosyan appetrosyan merged commit 744d8ad into iroha2-dev Jun 29, 2023
@appetrosyan appetrosyan deleted the swarm-single-file-emit branch June 29, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants