-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #2373: kagami swarm file
and kagami swarm dir
#3585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x009922
added
Enhancement
New feature or request
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
labels
Jun 8, 2023
0x009922
force-pushed
the
swarm-single-file-emit
branch
from
June 8, 2023 03:40
40e5ba7
to
cb84ce8
Compare
0x009922
requested review from
s8sato,
appetrosyan,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev and
Erigara
as code owners
June 8, 2023 03:45
I don't think this PR has the right target. We should merge into |
0x009922
force-pushed
the
swarm-single-file-emit
branch
from
June 8, 2023 08:14
cb84ce8
to
16425cc
Compare
ATM of the PR creation, it was a direct successor of |
0x009922
force-pushed
the
swarm-single-file-emit
branch
from
June 13, 2023 02:21
16425cc
to
0e45533
Compare
appetrosyan
force-pushed
the
swarm-single-file-emit
branch
from
June 19, 2023 08:20
0e45533
to
5e86a1a
Compare
appetrosyan
reviewed
Jun 20, 2023
appetrosyan
previously approved these changes
Jun 20, 2023
appetrosyan
force-pushed
the
swarm-single-file-emit
branch
from
June 20, 2023 07:45
5e86a1a
to
9b5f229
Compare
ilchu
previously approved these changes
Jun 21, 2023
Closed
appetrosyan
previously approved these changes
Jun 26, 2023
0x009922
force-pushed
the
swarm-single-file-emit
branch
from
June 26, 2023 11:47
5a94a83
to
f8a9de6
Compare
appetrosyan
approved these changes
Jun 26, 2023
0x009922
force-pushed
the
swarm-single-file-emit
branch
from
June 27, 2023 00:09
f8a9de6
to
253bae2
Compare
ilchu
approved these changes
Jun 27, 2023
Signed-off-by: Dmitry Balashov <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
Co-authored-by: Aleksandr Petrosyan <[email protected]> Signed-off-by: 0x009922 <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
0x009922
force-pushed
the
swarm-single-file-emit
branch
from
June 28, 2023 09:59
253bae2
to
e8124de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#3475 introduces
kagami swarm
command, but it works only in directory mode. Now it is possible to produce both a "battery-included" directory and just a single file. The latter usage is especially helpful to generate sample docker-compose configurations to store them in the repo (docker-compose.yml
,docker-compose.single.yml
etc):Linked issue
Closes #2373
Benefits
We can automatise Docker Compose configurations generation and avoid problems with having outdated files in the repo. It will help the community.
Checklist
--outfile
and--outdir
options, use positionals insteadkagami swarm
in CI #3648