-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checks in Provider put() method in Java Security Restricted Mode #610
Conversation
@keithc-ca Please help to review and advise. |
closed/src/java.base/share/classes/openj9/internal/security/RestrictedSecurity.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/openj9/internal/security/RestrictedSecurity.java
Outdated
Show resolved
Hide resolved
e0a1b84
to
790fd00
Compare
Signed-off-by: Tao Liu <[email protected]>
In the future, please put more information in the commit message. All, or most, of the description should be there so someone reviewing this in the future can understand (at least most of) the context and motivation for the change without needing to consult this pull request. |
Jenkins test sanity.openjdk amac jdknext |
Jenkins test sanity.openjdk amac jdknext depends ibmruntimes/openj9-openjdk-jdk#openj9-staging |
This will have to wait until the openj9 branch advances to include so it will compile in the presence of eclipse-openj9/openj9#17722. |
Started a new acceptance build https://openj9-jenkins.osuosl.org/job/Pipeline-OpenJDK-Acceptance/490/ |
That build has promoted. |
Jenkins test sanity.openjdk amac jdknext |
@keithc-ca For backport this PR, which JDK version needed? JDK11, JDK17 and JDK20? |
If you want to back-port this, the sequence would be jdk21, jdk17, jdk11 and jdk8. There will be no more releases of jdk20. |
Signed-off-by: Tao Liu [email protected]
This PR is for adding the services check in Provider legacy "put()" method and debug info in Java Security Restricted Mode.
The legacy “put()” method is for adding the services and it is used by provider SUN and SunEC in Semeru OpenJDK8. From OpenJDK11 and above versions, all those usages of “put()” method changed to "putService()" method. But we still need to check the services which are added by the legacy “put()” method in Java Security Restricted Mode. So, updated the codes for checking the registered services, only allowed the needed services be stored in the "legacyMap".