Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test data for nxos arp detail pr1928 #1

Conversation

mjbear
Copy link

@mjbear mjbear commented Dec 6, 2024

Updates to networktocode/pull/1928

  • Add test data
  • Modify test data to include cases that have all three (flag) symbols
  • Remove unneeded backspace escaping on the symbols that are within square brackets

* Notice, I added the other two symbols so they're covered in the test
  data too.
@mjbear mjbear changed the base branch from master to Issue#1923_Cisco_NXOS_ARP_Detail December 6, 2024 16:37
@mjbear mjbear changed the title Nxos arp detail pr1928 Test data for nxos arp detail pr1928 Dec 6, 2024
@icarus747 icarus747 merged commit 3cca3a1 into icarus747:Issue#1923_Cisco_NXOS_ARP_Detail Dec 6, 2024
@icarus747
Copy link
Owner

@mjbear
Thank you for working with me on this. I'm new to the github etiquette and testing. I have the test environment up and invoked the test per the docs you posted earlier. Your example of adding a new 'flag' raw and yaml file is helpful for understanding how to attach the test.

@mjbear mjbear deleted the nxos_arp_detail_pr1928 branch December 6, 2024 18:12
@mjbear
Copy link
Author

mjbear commented Dec 6, 2024

@mjbear Thank you for working with me on this. I'm new to the github etiquette and testing. I have the test environment up and invoked the test per the docs you posted earlier. Your example of adding a new 'flag' raw and yaml file is helpful for understanding how to attach the test.

You're welcome.
Glad I can be helpful. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants