Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1923 Optional Flag values ignored #1928

Merged

Conversation

icarus747
Copy link
Contributor

Changed the Data regex to include optional flags (#, *, +) for some Cisco devices ad the end of an ARP entry line.

Data
  ^${IP_ADDRESS}\s+${AGE}\s+${MAC_ADDRESS}\s+${INTERFACE}\s+${PHYSICAL_INTERFACE}(?:\s+[\#\*\+])?\s*$$ -> Record
  ^. -> Error

To address issue #1923

@mjbear
Copy link
Contributor

mjbear commented Dec 6, 2024

@icarus747
There needs to be test data (raw and parsed) in addition to the template changes.

https://github.com/networktocode/ntc-templates/blob/master/docs/dev/dev_environment.md
https://github.com/networktocode/ntc-templates/blob/master/docs/dev/dev_parser.md#development-helper-scripts

I'll review the template and submit some changes shortly.
Once I send my changes you can review them and then click the button to accept them. 🙂

@mjbear
Copy link
Contributor

mjbear commented Dec 6, 2024

@icarus747
Here's a PR icarus747/pull/1 with your test data from issue #1923.
I monkeyed with it so there are cases for all three symbols. 😁

I would still recommend experimenting with the test scripts and so forth before your next contribution! 😀

Test data for nxos arp detail pr1928
@jmcgill298 jmcgill298 merged commit c22240d into networktocode:master Dec 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants