feat: add IBC prefix for ics-08 clients and bugfixes #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add revision number but for now do not add support for resseting chain height
AntonAndell
requested review from
redlarva,
ibrizsabin and
nightowl121
as code owners
AntonAndell
force-pushed
the
808-investigate-commitment-prefix-usage-in-ibc-java
branch
from
3f0c1e5 to
2a6b7d7
Compare
AntonAndell
force-pushed
the
808-investigate-commitment-prefix-usage-in-ibc-java
branch
from
2a6b7d7 to
ec773cf
Compare
AntonAndell
force-pushed
the
808-investigate-commitment-prefix-usage-in-ibc-java
branch
from
537cfa2 to
0cb76eb
Compare
AntonAndell
force-pushed
the
807-add-client-specific-hashing-on-ack-and-packet-data
branch
2 times, most recently
from
dc07e0d to
7d0585a
Compare
…on-ack-and-packet-data' into 808-investigate-commitment-prefix-usage-in-ibc-java
AntonAndell
merged commit a7af666
into
807-add-client-specific-hashing-on-ack-and-packet-data
4 checks passed
AntonAndell
deleted the
808-investigate-commitment-prefix-usage-in-ibc-java
branch
AntonAndell
added a commit
that referenced
this pull request
Feb 12, 2024
* feat: hash depending on client type * feat: add IBC prefix for ics-08 clients and bugfixes (#826) * feat: Add revision number to light client heights Add revision number but for now do not add support for resseting chain height * revert to using two clients * feat: add IBC prefix for ics-08 clients and bugfixes * fix: hash ack value before sending to verify membership for ics8 client --------- Co-authored-by: izyak <[email protected]> --------- Co-authored-by: izyak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist