Prettier 3.0 #171

mattbrannon · 2023-07-06T15:20:28Z

Prettier just released a new major version which includes some breaking changes to the API. Currently Prettier 3.0 causes the extension to throw a type error:

Error: Expected `input` to be a `string`, got `object` 
TypeError: Expected `input` to be a `string`, got `object`

I haven't looked into the source code for Prettier or this extension for a while so I don't know how difficult of a fix this is.

If anyone is having this same issue, the short term solution is to explicitly install a version of prettier before 3.0.

npm i -D [email protected]

The text was updated successfully, but these errors were encountered:

mattbrannon · 2023-07-08T03:32:22Z

More info in this PR

Catatomik · 2023-07-31T19:35:48Z

Any update on this ?
Is there a roadmap ?

github-actions · 2023-08-31T17:24:57Z

This issue is stale because it has been open for 14 days with no activity.

HoltMansfield · 2023-09-07T17:47:46Z

Please fix this. I can no longer use your plugin and I have severe health problems. I need this automation.

zhangjie1314 · 2023-09-13T08:19:36Z

Please fix it, thank you.

PrinceGuidon · 2023-09-25T10:01:42Z

Any update on this?

danielwerg · 2023-10-14T04:32:43Z

prettier/prettier-eslint#901 just got merged.

arange · 2023-10-18T00:27:18Z

Any update? Much appreciated

maxkostow · 2023-10-20T18:29:49Z

Seems like this should be fixed by #187

idahogurl · 2023-10-27T18:46:10Z

Sorry for the lack of response. I've been dealing with medical issues in addition to everything else. Someone created a PR to update everything (#189) but it needs some changes and I don't have much time to help. Also, the automated deploy isn't working and could use some help there.

idahogurl · 2023-10-27T21:43:05Z

I did a little testing of #189 and upgrading to Prettier 3 is not an option at this time. I am getting the same error as prettier/prettier-vscode#3114 describes when I try to run my extension. Prettier 3 added a dynamic import() in its .cjs file, making ESM support required. VS Code only supports CommonJS (CJS) however. Basically we are stuck with Prettier 2 unless I decide to bundle Prettier 3 and somehow get the bundler to process the dynamic import.

KillDozerX2 · 2023-11-01T13:03:30Z

Sorry for the lack of response. I've been dealing with medical issues in addition to everything else. Someone created a PR to update everything (#189) but it needs some changes and I don't have much time to help. Also, the automated deploy isn't working and could use some help there.

Do you still need help resolving automated deploys?

idahogurl · 2023-11-01T18:07:27Z

@KillDozerX2 I do still need help with automated deploys. I'm using Auto (docs) to automate the deploys. I think I have it setup wrong. When I run the release workflow it should see there is a new version and publish the extension, but it doesn't. Here is their example: https://intuit.github.io/auto/docs/build-platforms/github-actions

I think it only works with this workflow: https://intuit.github.io/auto/docs/generated/shipit#release-pipeline

JounQin · 2023-11-22T04:45:16Z

I would recommend to migrate to changesets instead.

And it maybe great to migrate this repo into the prettier org just like prettier-eslint, how do you think?

exceptionptr · 2023-11-25T10:19:49Z

I created something based on your work @idahogurl.
The key was to use worker_threads. Prettier is doing this as well for their VSCode extension.

Tested with:

"prettier": "3.1.0"
"prettier-eslint": "16.1.2"
"@typescript-eslint/parser": "6.12.0"
"typescript": "5.3.2"

(https://github.com/0x2aff/vscode-prettier-eslint)
(https://marketplace.visualstudio.com/items?itemName=exceptionptr.vscode-prettier-eslint)

idahogurl · 2023-11-27T16:58:36Z

@0x2aff I actually tried using worker threads as well but it wasn't applying the Prettier config in my tests. I'll have to try your code and see if I can't get my tests to pass.

JounQin · 2023-11-27T17:05:14Z

Or you can try https://github.com/un-ts/synckit to simplify.

idahogurl · 2023-11-27T17:58:21Z

@0x2aff I tried your extension and it has the same problem with my test file. I'll create an issue in your repository and provide the files needed to reproduce.

DucNg · 2023-12-01T16:01:20Z

Here is a PR attempting to fix the issue, does it works for you? #198

issue-to-branch · 2023-12-01T17:40:04Z

Click here to create a branch for this issue

issue-to-branch · 2023-12-01T17:40:15Z

Branch 171-prettier-3-0
created for this issue. Run command below in your terminal to checkout branch.
git fetch && git checkout 171-prettier-3-0

idahogurl · 2023-12-01T19:36:04Z

I do have a beta version of the extension working with Prettier 3. It has some breaking changes:

prettier-eslint is now required as a dev dependency
Prettier v3.0 is now required
ESLint >= v8.52.0 is now required

Download and install the extension from here:
vs-code-prettier-eslint-6.0.0-beta.vsix.zip

Once I have enough people testing it, I will making it available as a general release. Let me know if you find any issues with it.

mattbrannon · 2023-12-09T02:12:02Z

@idahogurl The latest beta version works great for me. I'm not seeing any noticeable delay when formatting.

idahogurl · 2023-12-09T04:04:22Z

@netux @jaschaephraim Try this version. I preloaded the worker.
vs-code-prettier-eslint-6.0.0-beta.2.vsix.zip

jaschaephraim · 2023-12-10T00:59:06Z

@idahogurl beta 2 performs just like beta 1, still a short delay on the first run only

jaulz · 2023-12-12T14:24:58Z

@DucNg Did you install prettier-eslint locally?

I installed prettier-eslint both globally as well as locally in my project but still I see the issue:

Error: Cannot find module 'prettier-eslint'
Require stack:
- /Users/julian/.vscode/extensions/rvest.vs-code-prettier-eslint-6.0.0-beta.2/dist/extension.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-amd.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-fork.js
- 
	at Module._resolveFilename (node:internal/modules/cjs/loader:1129:15)
	at s._resolveFilename (node:electron/js2c/utility_init:2:2786)
	at h.resolve (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:4:709)

Any idea what else could be missing?

idahogurl · 2023-12-12T23:23:52Z

@jaulz All I can think of is having you restart VS Code and creating a minimal reproduction project.

Jmyerzzz · 2023-12-14T06:03:17Z

what versions of prettier and prettier-eslint can I downgrade to to restore format on save functionality?

uberubert · 2023-12-14T14:52:40Z

I've been struggling with lack of format on save all day and haven't found a solution. I'll just add my +1.

idahogurl · 2023-12-14T16:07:02Z

@Jmyerzzz @uberubert Format on save should be working. Can you provide further information as to exactly isn't working and perhaps a minimal reproduction project? Also, what version of VS Code are you running? I've been using the beta for a while now and haven't had issues. Last thing, have you checked the Output (described in the README in the troubleshooting section)? If there is an error it will show up there.

JU12000 · 2023-12-14T18:09:06Z

@idahogurl Using beta 1 at the moment in a mid-sized monorepo and not seeing any issues with formatting. However if I change my prettier or eslint config files I have to reload VSCode in order for the extension to pick up the changes and format properly again. Otherwise it works great, thank you for maintaining this extension 👍.

Jmyerzzz · 2023-12-14T19:37:01Z

@idahogurl

VSCode v1.85.1
prettier v3.1.1
prettier-eslint v16.1.2

Output:
TypeError: Expected input to be a string, got object

idahogurl · 2023-12-14T19:46:48Z

@Jmyerzzz You need to download and install the beta 1 version of the extension. Use this link
https://github.com/idahogurl/vs-code-prettier-eslint/files/13621102/vs-code-prettier-eslint-6.0.0-beta.1.vsix.zip

idahogurl · 2023-12-14T20:54:34Z

@netux @jaschaephraim Please try this new version to see if it speeds things up
vs-code-prettier-eslint-6.0.0-beta.3.vsix.zip

jaschaephraim · 2023-12-15T22:20:32Z

Still seeing the same short delay on the first format, very fast after that.

ibussieres · 2024-01-09T17:28:21Z

I've been using beta3 all morning, It seems to be working fine! I'll be using it daily, so unless I report back, it's safe to assume that it's working well for me as well.

"eslint": "^8.52.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-prettier": "^5.1.2",
"prettier": "^3.1.1",
"prettier-eslint": "^16.2.0",

AdamGerthel · 2024-01-10T17:06:55Z

Beta 3 is working well for me

jinsley8 · 2024-01-12T05:27:53Z

If you go to vscode settings and find Prettier: Prettier Path option, make sure this is empty.

My vscode keeps adding it back somehow then prettier stops working again.

novarolV · 2024-01-15T15:07:33Z

@idahogurl
Beta 3 is throwing this error on Windows for me:

Error: Only URLs with a scheme in: file and data are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:' 
Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only URLs with a scheme in: file and data are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'
    at new NodeError (node:internal/errors:399:5)
    at throwIfUnsupportedURLScheme (node:internal/modules/esm/resolve:1065:11)
    at defaultResolve (node:internal/modules/esm/resolve:1141:3)
    at nextResolve (node:internal/modules/esm/loader:163:28)
    at ESMLoader.resolve (node:internal/modules/esm/loader:838:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
    at ESMLoader.import (node:internal/modules/esm/loader:525:22)
    at importModuleDynamically (node:internal/modules/esm/translators:110:35)
    at importModuleDynamicallyCallback (node:internal/process/esm_loader:35:14)
    at file:///c:/Users/username/.vscode/extensions/rvest.vs-code-prettier-eslint-6.0.0-beta.3/dist/worker.mjs:1:1394

Beta 1 doesn't have this issue.

VSCode:

Version: 1.85.1 (system setup)
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
Date: 2023-12-13T09:49:37.021Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.19045

"@typescript-eslint/parser": "^6.18.1",
"@vue/eslint-config-prettier": "^8.0.0",
"@vue/eslint-config-typescript": "^12.0.0",
"eslint": "^8.56.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-prettier": "^5.1.3",
"eslint-plugin-vue": "^9.20.1",
"prettier": "^3.2.2",
"prettier-eslint": "^16.2.0",
"vue-eslint-parser": "^9.4.0"

JounQin · 2024-01-15T15:15:36Z

@novarolV Can you help to test via PR based of https://github.com/idahogurl/vs-code-prettier-eslint/pull/199/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R59 and #199 (comment)

novarolV · 2024-01-16T11:28:58Z

@JounQin @idahogurl I created a PR with proposed change to fix the file path error on Windows.

robertheessels · 2024-01-17T11:54:11Z

Beta 3 works great in my project. Thank you!

phun-ky · 2024-01-31T13:32:37Z

@idahogurl you are doing an awesome job here <3

Do we have any eta? Stay well!

idahogurl · 2024-02-06T21:02:07Z

@phun-ky @ozyx It's been released. Make sure to install the prettier-eslint package or else it won't work :)

ozyx · 2024-02-06T21:03:55Z

@phun-ky @ozyx It's been released.

You're awesome! Thanks!

JounQin · 2024-02-06T23:20:48Z

@idahogurl The v6 tag/release is missing.

robertheessels · 2024-02-08T15:33:02Z

Works great. Thank you!

issue-to-branch · 2024-03-26T09:07:38Z

Branch 171-prettier-3-0
created for this issue. Run command below in your terminal to checkout branch.
git fetch && git checkout 171-prettier-3-0

github-actions bot added the stale label Aug 31, 2023

github-actions bot removed the stale label Sep 8, 2023

idahogurl mentioned this issue Oct 27, 2023

Update prettier-eslint 15.0.1 → 16.1.1 (major) #187

Closed

idahogurl mentioned this issue Nov 10, 2023

Update prettier-eslint 15.0.1 → 16.1.2 (major) #192

Closed

DucNg mentioned this issue Dec 1, 2023

Update to prettier 3, attempt to fix #171 #198

Closed

idahogurl self-assigned this Dec 1, 2023

idahogurl mentioned this issue Dec 1, 2023

chore: update eslint, prettier, eslint-prettier to current #189

Closed

idahogurl mentioned this issue Dec 2, 2023

fix: use synckit to support Prettier 3 #199

Merged

danielptv mentioned this issue Dec 17, 2023

chore(deps): bump prettier from 2.8.8 to 3.1.1 danielptv/bookmark-bar-switcher#215

Closed

novarolV mentioned this issue Jan 16, 2024

fix: resolve absolute path to file url correctly #206

Merged

ozyx mentioned this issue Feb 6, 2024

Upgrade prettier and eslint compatibility libraries to latest nasa/openmct#7478

Merged

15 tasks

idahogurl closed this as completed in #199 Feb 6, 2024

Prettier 3.0 #171

Prettier 3.0 #171

Comments

mattbrannon commented Jul 6, 2023 • edited Loading

mattbrannon commented Jul 8, 2023

Catatomik commented Jul 31, 2023

github-actions bot commented Aug 31, 2023

HoltMansfield commented Sep 7, 2023

zhangjie1314 commented Sep 13, 2023

PrinceGuidon commented Sep 25, 2023

danielwerg commented Oct 14, 2023

arange commented Oct 18, 2023

maxkostow commented Oct 20, 2023

idahogurl commented Oct 27, 2023 • edited Loading

idahogurl commented Oct 27, 2023 • edited Loading

KillDozerX2 commented Nov 1, 2023

idahogurl commented Nov 1, 2023

JounQin commented Nov 22, 2023

exceptionptr commented Nov 25, 2023 • edited Loading

idahogurl commented Nov 27, 2023

JounQin commented Nov 27, 2023

idahogurl commented Nov 27, 2023

DucNg commented Dec 1, 2023

issue-to-branch bot commented Dec 1, 2023

issue-to-branch bot commented Dec 1, 2023

idahogurl commented Dec 1, 2023 • edited Loading

mattbrannon commented Dec 9, 2023

idahogurl commented Dec 9, 2023

jaschaephraim commented Dec 10, 2023

jaulz commented Dec 12, 2023

idahogurl commented Dec 12, 2023

Jmyerzzz commented Dec 14, 2023

uberubert commented Dec 14, 2023

idahogurl commented Dec 14, 2023 • edited Loading

JU12000 commented Dec 14, 2023

Jmyerzzz commented Dec 14, 2023

idahogurl commented Dec 14, 2023

idahogurl commented Dec 14, 2023

jaschaephraim commented Dec 15, 2023

ibussieres commented Jan 9, 2024 • edited Loading

AdamGerthel commented Jan 10, 2024

jinsley8 commented Jan 12, 2024

novarolV commented Jan 15, 2024 • edited Loading

JounQin commented Jan 15, 2024 • edited Loading

novarolV commented Jan 16, 2024

robertheessels commented Jan 17, 2024

phun-ky commented Jan 31, 2024

idahogurl commented Feb 6, 2024 • edited Loading

ozyx commented Feb 6, 2024

JounQin commented Feb 6, 2024

robertheessels commented Feb 8, 2024

issue-to-branch bot commented Mar 26, 2024

mattbrannon commented Jul 6, 2023 •

edited

Loading

idahogurl commented Oct 27, 2023 •

edited

Loading

idahogurl commented Oct 27, 2023 •

edited

Loading

exceptionptr commented Nov 25, 2023 •

edited

Loading

idahogurl commented Dec 1, 2023 •

edited

Loading

idahogurl commented Dec 14, 2023 •

edited

Loading

ibussieres commented Jan 9, 2024 •

edited

Loading

novarolV commented Jan 15, 2024 •

edited

Loading

JounQin commented Jan 15, 2024 •

edited

Loading

idahogurl commented Feb 6, 2024 •

edited

Loading