fix: resolve absolute path to file url correctly #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2024
Closed
JounQin
reviewed
Jan 16, 2024
src/worker.mjs
Outdated
| @@ -15,7 +16,7 @@ runAsWorker( | |||
| text, prettierEslintPath, filePath, extensionConfig, | |||
| }) => { | |||
| const format = /** @type {typeof import('prettier-eslint')} */ ( | |||
| (await import(prettierEslintPath)).default | |||
| (await import(pathToFileURL(prettierEslintPath))).default | |||
There was a problem hiding this comment.
Suggested change
| (await import(pathToFileURL(prettierEslintPath))).default | |
| (await import(isAbsolutePath(prettierEslintPath) ？ pathToFileURL(prettierEslintPath) : prettierEslintPath)).default |
There was a problem hiding this comment.
Makes sense, see my new commit.
novarolV
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures absolute file path to be resolved correctly as File URL on Windows.
Fixes issue raised by me here
NodeJS references:
File URLs
url.pathToFileURL